Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused dependency ethers #1168

Merged
merged 1 commit into from
Aug 7, 2023
Merged

chore: remove unused dependency ethers #1168

merged 1 commit into from
Aug 7, 2023

Conversation

Dhaiwat10
Copy link
Member

Closes #1133

@Dhaiwat10 Dhaiwat10 mentioned this pull request Aug 7, 2023
Closed
@Dhaiwat10 Dhaiwat10 self-assigned this Aug 7, 2023
@Dhaiwat10 Dhaiwat10 enabled auto-merge (squash) August 7, 2023 13:44
nedsalk
nedsalk approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@nedsalk nedsalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should take a look at other dependencies as well. There's probably more unused ones.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 84.77% 4586/5410
🟡 Branches 65.36% 698/1068
🟡 Functions 74.93% 792/1057
🟢 Lines 84.89% 4382/5162

Test suite run success

1125 tests passing in 192 suites.

Report generated by 🧪jest coverage report action from 00f85a2

@Dhaiwat10 Dhaiwat10 merged commit a64b67b into master Aug 7, 2023
7 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/purge-ethers branch August 7, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbate danielbate danielbate approved these changes

@nedsalk nedsalk nedsalk approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@camsjams camsjams Awaiting requested review from camsjams

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

Assignees

@Dhaiwat10 Dhaiwat10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump major version of ethers from v5 to v6
3 participants
@Dhaiwat10 @danielbate @nedsalk