-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: formatted all sway projects #1211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedsalk
requested review from
digorithm,
arboleya,
camsjams,
Torres-ssf,
Dhaiwat10 and
danielbate
as code owners
August 24, 2023 16:44
Coverage report
Test suite run success1192 tests passing in 204 suites. Report generated by 🧪jest coverage report action from aed28ed |
Torres-ssf
previously approved these changes
Aug 24, 2023
arboleya
reviewed
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the issue:
fuels-ts/.github/workflows/test.yaml
Lines 28 to 29 in 7dc8cca
- name: Forc Format Check | |
run: pnpm forc:check |
danielbate
previously approved these changes
Aug 25, 2023
danielbate
approved these changes
Aug 26, 2023
Torres-ssf
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just ran
./scripts/forc-format.sh
in the root directory.We should put
forc fmt --check
somewhere in our CI to ensure proper formatting of all our sway projects, but that's for another PR. The rust-sdk has all of their sway projects in one workspace so they just runforc fmt --check
on that workspace.