Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: formatted all sway projects #1211

Merged
merged 6 commits into from
Aug 28, 2023
Merged

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Aug 24, 2023

Just ran ./scripts/forc-format.sh in the root directory.

We should put forc fmt --check somewhere in our CI to ensure proper formatting of all our sway projects, but that's for another PR. The rust-sdk has all of their sway projects in one workspace so they just run forc fmt --check on that workspace.

@nedsalk nedsalk enabled auto-merge (squash) August 24, 2023 16:47
@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 84.99% 4869/5729
🟡 Branches 65.81% 739/1123
🟡 Functions 74.24% 827/1114
🟢 Lines 85.13% 4653/5466

Test suite run success

1192 tests passing in 204 suites.

Report generated by 🧪jest coverage report action from aed28ed

Torres-ssf
Torres-ssf previously approved these changes Aug 24, 2023
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the issue:

- name: Forc Format Check
run: pnpm forc:check

@nedsalk nedsalk requested a review from arboleya August 25, 2023 11:41
danielbate
danielbate previously approved these changes Aug 25, 2023
@nedsalk nedsalk dismissed stale reviews from danielbate and Torres-ssf via aed28ed August 25, 2023 17:29
@nedsalk nedsalk merged commit c3ed0f2 into master Aug 28, 2023
8 checks passed
@nedsalk nedsalk deleted the ns/chore/format-all-projects branch August 28, 2023 11:12
Torres-ssf pushed a commit that referenced this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants