test: add throw scenarios to simulate and dryRun
#1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbate
requested review from
digorithm,
arboleya,
camsjams,
Torres-ssf,
Dhaiwat10 and
nedsalk
as code owners
danielbate
changed the title
simulate and dryRun
Coverage report
Test suite run success1205 tests passing in 208 suites. Report generated by 🧪jest coverage report action from 4558de1 |
arboleya
previously approved these changes
Sep 12, 2023
There was a problem hiding this comment.
@danielbate You could have used the safeExec utility in these try/catch validations, but as you are not yet dealing with FuelErrors, these expectations will probably need to be aligned with:
cc @Torres-ssf
|
@arboleya good idea 👍🏻 |
arboleya
approved these changes
Sep 13, 2023
Dhaiwat10
approved these changes
Sep 13, 2023
Torres-ssf
approved these changes
Sep 13, 2023
camsjams
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following forum post asks whether a wallet with no funding should be able to perform a read only call. Current specs detail that this is not possible, as per our own TS documentation.
This PR will add some test cases to the demo typegen application to directly replicate the above forum post, as well as additional expectations to fuel-gauge for both
simulateanddryRunthrow expectations. This is already explained in the documentation.