Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve predicate vector input support #1247

Merged
merged 14 commits into from
Sep 14, 2023
Merged

feat: improve predicate vector input support #1247

merged 14 commits into from
Sep 14, 2023

Conversation

danielbate
Copy link
Contributor

Closes #1083

@danielbate danielbate self-assigned this Sep 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements
84.42% (+0.01% 🔼)
 4958/5873
🟡 Branches 65.65% 751/1144
🟡 Functions 73.94% 834/1128
🟢 Lines
84.49% (+0.01% 🔼)
 4734/5603

Test suite run success

1207 tests passing in 208 suites.

Report generated by 🧪jest coverage report action from 236097f

@danielbate danielbate marked this pull request as ready for review September 12, 2023 16:06
camsjams
camsjams approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@camsjams camsjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I will check the math.

The +1 to offset I tried too, I think, I'm glad it worked. I think I must have just been too close to the problem

@danielbate danielbate enabled auto-merge (squash) September 14, 2023 07:49
@danielbate danielbate merged commit 3a39fea into master Sep 14, 2023
8 checks passed
@danielbate danielbate deleted the db/feat/predicate-vector-input-support branch September 14, 2023 11:24
@github-actions github-actions bot mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camsjams camsjams camsjams approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@danielbate danielbate

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Predicate Vector input support
3 participants
@danielbate @arboleya @camsjams