-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: represent small values as single bytes #1435
Closed
danielbate
wants to merge
88
commits into
beta-5
from
db/feat/represent-small-values-as-single-bytes
Closed
feat!: represent small values as single bytes #1435
danielbate
wants to merge
88
commits into
beta-5
from
db/feat/represent-small-values-as-single-bytes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Show files with reduced coverage 🔻
Test suite run success1422 tests passing in 250 suites. Report generated by 🧪jest coverage report action from 82b53fa |
…s://github.com/FuelLabs/fuels-ts into db/feat/represent-small-values-as-single-bytes
…ub.com:FuelLabs/fuels-ts into db/feat/represent-small-values-as-single-bytes
danielbate
requested review from
digorithm,
camsjams,
Torres-ssf and
Dhaiwat10
as code owners
November 21, 2023 08:52
arboleya
requested changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning
This PR should not be merged yet.
Please, don't resolve this conversation.
Closing as this work is included in #1407 so the source of truth review should be there |
danielbate
deleted the
db/feat/represent-small-values-as-single-bytes
branch
February 22, 2024 09:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
New Test Scenarios
New isolated tests are being done at:
packages/fuel-gauge/src/small-bytes.test.ts
Failing tests
apps/docs-snippets/src/guide/contracts/configurable-constants.test.ts
apps/docs-snippets/src/guide/scripts/script-with-configurable.test.ts
apps/docs-snippets/src/guide/types/options.test.ts
apps/docs-snippets/src/guide/types/tuples.test.ts
apps/docs-snippets/src/guide/types/vector.test.ts
packages/abi-coder/test/interface.test.ts
packages/fuel-gauge/src/advanced-logging.test.ts
packages/fuel-gauge/src/configurable-contract.test.ts
packages/fuel-gauge/src/contract.test.ts
packages/fuel-gauge/src/coverage-contract.test.ts
packages/fuel-gauge/src/predicate/predicate-configurables.test.ts
packages/fuel-gauge/src/predicate/predicate-with-contract.test.ts
packages/fuel-gauge/src/script-with-configurable.test.ts
packages/fuel-gauge/src/script-with-vectors.test.ts
packages/fuel-gauge/src/vector-types.test.ts
packages/fuel-gauge/src/vectors.test.ts
Internal Docs
This is the summary of the new encoding/decoding scheme:
fuels-ts/packages/abi-coder/src/coders/abstract-coder.ts
Lines 9 to 47 in de19b90