-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Vitepress codeInContextPlugin
#1668
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Torres-ssf
added
docs
Requests pertinent to documentation
chore
Issue is a chore
labels
Jan 19, 2024
Torres-ssf
requested review from
digorithm,
arboleya,
Dhaiwat10,
danielbate and
nedsalk
as code owners
January 19, 2024 20:26
Coverage report
Show new covered files 🐣
Test suite run success1498 tests passing in 264 suites. Report generated by 🧪jest coverage report action from 7f10801 |
arboleya
reviewed
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
V Nice ❤️ |
danielbate
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arboleya
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces a refactor of the Vitepress
codeInContextPlugin
. The motivation for this refactor is to improve code readability and maintainability.This has been done by splitting the plugin's code into smaller functions. Additionally, comments were added throughout the code for a better understanding of its operation.
A test suite was also added.