Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: remove externalLoggedTypes from Interface class #1936

Merged
merged 24 commits into from
Mar 26, 2024
Merged

chore!: remove externalLoggedTypes from Interface class #1936

merged 24 commits into from
Mar 26, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Mar 25, 2024 •
edited

Breaking Changes

  • The method Interface.updateExternalLoggedTypes was removed.

@Torres-ssf Torres-ssf added chore Issue is a chore mainnet labels Mar 25, 2024
@Torres-ssf Torres-ssf self-assigned this Mar 25, 2024
@fuel-service-user
Copy link
Contributor

fuel-service-user commented Mar 25, 2024 •
edited

✨ A PR has been created under the rc-1936 tag on fuels-wallet repo.
FuelLabs/fuels-wallet#1207

@Torres-ssf Torres-ssf mentioned this pull request Mar 25, 2024
Merged
danielbate
danielbate reviewed Mar 26, 2024
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and good tests, couple questions.

packages/account/src/providers/transaction-response/getDecodedLogs.ts Show resolved Hide resolved
packages/program/src/functions/invocation-results.ts Outdated Show resolved Hide resolved
packages/program/src/functions/invocation-results.ts Show resolved Hide resolved
@nedsalk nedsalk self-requested a review March 26, 2024 12:33
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
81.27%(-0.06%) 71.68%(-0.16%) 78.83%(-0.05%) 81.36%(-0.07%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/abi-coder/src/Interface.ts 71.42%
(+9.66%)		 56.25%
(+6.25%)		 81.25%
(+4.78%)		 70%
(+8.89%)

@Torres-ssf Torres-ssf merged commit 3ebb9bc into master Mar 26, 2024
15 checks passed
@Torres-ssf Torres-ssf deleted the st/chore/remove-external-logged-from-interface branch March 26, 2024 13:47
@fuel-service-user fuel-service-user mentioned this pull request Mar 26, 2024
Merged
@nedsalk nedsalk mentioned this pull request Mar 28, 2024
Merged
@danielbate danielbate mentioned this pull request May 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbate danielbate danielbate approved these changes

@nedsalk nedsalk nedsalk approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove externalLoggedTypes from Interface
5 participants
@Torres-ssf @fuel-service-user @danielbate @petertonysmith94 @nedsalk