Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: decode logs from TXs submitted outside BaseInvocationScope #1940

Merged
merged 14 commits into from
Mar 27, 2024
Merged

feat: decode logs from TXs submitted outside BaseInvocationScope #1940

merged 14 commits into from
Mar 27, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Mar 25, 2024 •
edited
Loading

@Torres-ssf Torres-ssf added feat Issue is a feature mainnet labels Mar 25, 2024
@Torres-ssf Torres-ssf self-assigned this Mar 25, 2024
@Torres-ssf
Copy link
Contributor Author

Blocked by: #1936

I will rebase this after #1936 got merged

@Torres-ssf Torres-ssf added the blocked Something is blocking development on this issue label Mar 25, 2024
This was referenced Mar 25, 2024
Merged
Merged
Base automatically changed from st/chore/remove-external-logged-from-interface to master March 26, 2024 13:47
@Torres-ssf Torres-ssf force-pushed the st/feat/decoding-logs-from-script-transaction-request branch from b94e82e to 118e3de Compare March 26, 2024 14:05
@Torres-ssf Torres-ssf changed the title feat: decoding logs from TXs assembled with ScriptTransactionRequest feat: decode logs from TXs submitted outside BaseInvocationScope Mar 26, 2024
@Torres-ssf Torres-ssf removed the blocked Something is blocking development on this issue label Mar 26, 2024
@Torres-ssf Torres-ssf marked this pull request as ready for review March 26, 2024 14:18
arboleya
arboleya previously approved these changes Mar 26, 2024
View reviewed changes
petertonysmith94
petertonysmith94 previously approved these changes Mar 26, 2024
View reviewed changes
packages/fuel-gauge/src/advanced-logging.test.ts Outdated Show resolved Hide resolved
packages/fuel-gauge/src/advanced-logging.test.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
81.22%(-0.05%) 71.58%(-0.1%) 78.77%(-0.06%) 81.32%(-0.04%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 78.3%
(+0.16%)		 63.9%
(-0.22%)		 85.07%
(+0%)		 79%
(+0.15%)
🔴 packages/account/src/providers/transaction-request/script-transaction-request.ts 43.9%
(+1.4%)		 57.14%
(+0%)		 38.88%
(+0%)		 42.85%
(+1.39%)
🔴 packages/account/src/providers/transaction-response/transaction-response.ts 70.21%
(-1.88%)		 45%
(+0.56%)		 87.5%
(+0%)		 70.21%
(-1.88%)
🔴 packages/program/src/utils.ts 10.52%
(-7.66%)		 0%
(+0%)		 0%
(+0%)		 10.52%
(-7.66%)

@Torres-ssf Torres-ssf merged commit df882f1 into master Mar 27, 2024
15 checks passed
@Torres-ssf Torres-ssf deleted the st/feat/decoding-logs-from-script-transaction-request branch March 27, 2024 12:57
@fuel-service-user fuel-service-user mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decode Logs from TXs submitted outside BaseInvocationScope context
4 participants
@Torres-ssf @arboleya @petertonysmith94 @nedsalk