New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: fetch base asset ID from chain #1976
Conversation
…/feat/dynamic-base-asset
…/feat/dynamic-base-asset
packages/account/src/providers/transaction-request/transaction-request.ts
Outdated
Show resolved
Hide resolved
https://github.com/FuelLabs/fuels-ts/blob/db/feat/dynamic-base-asset/packages/account/README.md?plain=1#L57 |
…tal-forc-in-all-projects
…t/dynamic-base-asset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🍏
…tal-forc-in-all-projects
…t/dynamic-base-asset
…tal-forc-in-all-projects
…/chore/experimental-forc-in-all-projects
…github.com/FuelLabs/fuels-ts into db/feat/dynamic-base-asset
Changes have been made - please re-review
…/feat/dynamic-base-asset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wunderbar 🪄
Coverage Report:
Changed Files:
|
Closes #1948
Breaking Changes:
BaseAssetId
is no longer exported byfuels
. It must be fetched from the chain as it is configurable by the chain.TransactionRequest.addCoinOutput
now requires anassetId
, it no longer defaults to thebaseAssetId
.TransactionRequest.addChangeOutput
now requires anassetId
, it no longer defaults to thebaseAssetId
.TransactionRequest.fundWithFakeUtxos
now requires passing thebaseAssetId
as a function parameter. This is the only function that is base asset aware, so that it can be used specifically to estimate the transaction cost.CoinQuantityLike
now requires anAssetId
. Previously most of it's usages would default to theBaseAssetId
, as this must now be fetched, then it must be passed to the type.