Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: upgrade fuel-core to 0.26.0 #2217

Merged
merged 56 commits into from
May 4, 2024
Merged

chore!: upgrade fuel-core to 0.26.0 #2217

merged 56 commits into from
May 4, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Apr 30, 2024 •
edited

@Torres-ssf
update fuel core schema
1ad5164
@Torres-ssf
remove duplicate receipt on transactionStatusFragment
85a569c
@Torres-ssf
update dryRun related fragments
7061057
@Torres-ssf
update TxParametersFragment
c7b5960
@Torres-ssf
update snapshots configs
e7d70c0
@Torres-ssf
add empty state transition bytecode files
6b6f9ad
@Torres-ssf
update run node script
55dd539
@Torres-ssf
using fuel core 0.25.3
6018cd9
@Torres-ssf
added type for TransactionUpgrade
b1fef24
@Torres-ssf
add type UpgradePurpose
4fd51a0
@Torres-ssf
implement UpgradePurposeCoder
3ddf511
@Torres-ssf
add test suite for UpgradePurposeCoder
c2f85cf
@Torres-ssf
implement TransactionUpgradeCoder
68f4438
@Torres-ssf
enable encode/decode for TransactionUpgrade
d74ae1b
@Torres-ssf
add tests for TransactionUpgradeCoder
6016692
@Torres-ssf
add type for TransactionUpload
d4e9c89
@Torres-ssf
implement TransactionUploadCoder
4413dfb
@Torres-ssf
enable encode/decode for TransactionUploadCoder
f21cc72
@Torres-ssf
add tests for TransactionUploadCoder
337bc5a
@Torres-ssf
rename dryrunStatus property on CallResult
be91032
@Torres-ssf
update test
06d4851
@Torres-ssf
add new tx types to TransactionTypeName
c05dc43
@Torres-ssf
ajusting fixtures
e25c4ef
@Torres-ssf
add tip tp TransactionSummary
d528054
@Torres-ssf
add dryRunStatus TransactionCost
4e7de0b
@Torres-ssf
made ConsensusParameters type conform specs
0e883b2
@Torres-ssf
conform code with changes on ConsensusParameters type
cb33bb2
@Torres-ssf
adding TODOs
bc22c83
@Torres-ssf
updating tests
601cf36
@Torres-ssf
ensure launchNode generates an empty state_transition_bytecode file
cfc865e
@nedsalk nedsalk mentioned this pull request May 2, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024 •
edited by fuel-service-user

✨ A PR has been created under the rc-2217 tag on fuels-wallet repo.
FuelLabs/fuels-wallet#1268

@Torres-ssf Torres-ssf marked this pull request as ready for review May 3, 2024 10:39
petertonysmith94
petertonysmith94 previously approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please feel free to ignore my comments as non-critical - looks good to me!

I assume we're aware of the e2e failed test.

not enough coins to fit the target

packages/fuel-gauge/src/contract-factory.test.ts Outdated Show resolved Hide resolved
packages/account/src/test-utils/launchNode.ts Show resolved Hide resolved
@Torres-ssf @petertonysmith94
ajust import
fc4e66f 
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
maschad
maschad approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arboleya arboleya mentioned this pull request May 3, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 4, 2024

Coverage Report:

Lines Branches Functions Statements
79.53%(+0.27%) 69.28%(+0.02%) 77.43%(+0.07%) 79.65%(+0.27%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 68.16%
(-1.04%)		 55.34%
(-0.71%)		 77.1%
(-0.94%)		 68.39%
(-1%)
🔴 packages/account/src/providers/generated/operations.ts 93.79%
(-0.65%)		 100%
(+0%)		 80.95%
(-1.97%)		 94.28%
(-0.61%)
🔴 packages/account/src/providers/transaction-response/transaction-response.ts 71.15%
(+0%)		 50%
(-4.16%)		 87.5%
(+0%)		 71.15%
(+0%)
🔴 ✨ packages/account/src/providers/transaction-summary/calculate-tx-fee-for-summary.ts 100%
(+100%)		 91.66%
(+91.66%)		 100%
(+100%)		 100%
(+100%)
🔴 packages/account/src/providers/transaction-summary/operations.ts 94.59%
(+0.1%)		 70.9%
(+0%)		 92.5%
(+0.4%)		 93.33%
(+0.11%)
🔴 packages/account/src/test-utils/launchNode.ts 100%
(+0%)		 88.46%
(+0%)		 68.42%
(+0%)		 94.28%
(+0.11%)
🔴 packages/transactions/src/coders/transaction.ts 99.12%
(+0.56%)		 85.71%
(+5.71%)		 100%
(+0%)		 99.12%
(+0.55%)
🔴 ✨ packages/transactions/src/coders/upgrade-purpose.ts 93.33%
(+93.33%)		 75%
(+75%)		 100%
(+100%)		 93.54%
(+93.54%)

@arboleya arboleya merged commit 2990edb into master May 4, 2024
28 of 29 checks passed
@arboleya arboleya deleted the st/chore/upgrade-fuel-core-0.25.3 branch May 4, 2024 08:38
@fuel-service-user fuel-service-user mentioned this pull request May 4, 2024
Merged
@maschad maschad mentioned this pull request May 6, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@nedsalk nedsalk nedsalk left review comments

@maschad maschad maschad approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade fuel-core to 0.26.0 Possible issue with getTransactionSummary
5 participants
@Torres-ssf @arboleya @maschad @petertonysmith94 @nedsalk