Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: handle create fuels template scenarios for insufficient funds #2798

Merged
merged 16 commits into from
Jul 25, 2024

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Jul 19, 2024

Summary

This PR adds missing try-catch statements in some places where error handling is needed in case of insufficient funds in a wallet.

Checklist

  • I addedtests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

@Dhaiwat10 Dhaiwat10 added the chore Issue is a chore label Jul 19, 2024
@Dhaiwat10 Dhaiwat10 added this to the 0.x mainnet milestone Jul 19, 2024
@Dhaiwat10 Dhaiwat10 self-assigned this Jul 19, 2024
Copy link

vercel bot commented Jul 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-ts ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 9:56am

@Dhaiwat10 Dhaiwat10 changed the title chore: handle create fuels example dapp scenarios for insufficient funds chore: handle create fuels template scenarios for insufficient funds Jul 19, 2024
…:fuellabs/fuels-ts into dp/chore-create-fuels-insufficient-funds
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, comments inline

apps/create-fuels-counter-guide/src/app/script/page.tsx Outdated Show resolved Hide resolved
templates/nextjs/src/sway-api/contract-ids.json Outdated Show resolved Hide resolved
…:fuellabs/fuels-ts into dp/chore-create-fuels-insufficient-funds
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can directly link them to the faucet, otherwise, should we decided to move the Top-up from the top right hand corner, we will have to update all these toast messages

apps/create-fuels-counter-guide/src/app/page.tsx Outdated Show resolved Hide resolved
apps/create-fuels-counter-guide/src/app/page.tsx Outdated Show resolved Hide resolved
apps/create-fuels-counter-guide/src/app/script/page.tsx Outdated Show resolved Hide resolved
templates/nextjs/src/app/page.tsx Show resolved Hide resolved
templates/nextjs/src/app/predicate/page.tsx Outdated Show resolved Hide resolved
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.35%(-0.01%) 71.47%(-0.18%) 77.32%(+0.02%) 79.48%(-0.01%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/account.ts 82.31%
(+1.16%)
65.07%
(+1.14%)
82.35%
(+0.54%)
82%
(+1.15%)
🔴 packages/account/src/providers/provider.ts 67.31%
(-1.53%)
62.28%
(-1.54%)
73.49%
(-0.31%)
67.3%
(-1.49%)
🔴 packages/account/src/test-utils/launchNode.ts 98.27%
(+0.01%)
85.24%
(+0.5%)
100%
(+0%)
98.36%
(+0.02%)
🔴 packages/contract/src/contract-factory.ts 58.33%
(-0.29%)
46.42%
(+0.27%)
54.54%
(+0%)
58.33%
(-0.29%)
🔴 packages/contract/src/util.ts 93.75%
(+0.42%)
0%
(+0%)
66.66%
(+0%)
88.88%
(+0.65%)
🔴 packages/create-fuels/src/cli.ts 85.5%
(+0.21%)
37.5%
(-2.5%)
100%
(+0%)
85.5%
(+0.21%)

@Dhaiwat10 Dhaiwat10 merged commit 40a3510 into master Jul 25, 2024
20 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/chore-create-fuels-insufficient-funds branch July 25, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle create fuels example dApp scenarios for insufficient funds
6 participants