Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating pull request tasklist #2910

Merged
merged 6 commits into from
Aug 12, 2024
Merged

Conversation

arboleya
Copy link
Member

@arboleya arboleya commented Aug 11, 2024

Summary

I considered re-wording the PR tasklist, so all items must always be ☑️ completed.

This way, all tasks must be completed for a PR to be ready, adding consistency and removing ambiguity.

inconsistent

The tasklist 👇 for this PR already follows the new model for demo purposes:

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@arboleya arboleya added the chore Issue is a chore label Aug 11, 2024
@arboleya arboleya self-assigned this Aug 11, 2024
@arboleya arboleya enabled auto-merge (squash) August 11, 2024 18:50
@arboleya arboleya disabled auto-merge August 11, 2024 18:51
@arboleya arboleya changed the title Re-shaping template so all tasks can be completed chore: updating pull request template Aug 11, 2024
@arboleya arboleya changed the title chore: updating pull request template chore: updating pull request tasklist Aug 11, 2024
danielbate
danielbate previously approved these changes Aug 12, 2024
@arboleya arboleya enabled auto-merge (squash) August 12, 2024 15:18
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.76%(+0%) 72.12%(-0.04%) 77.81%(+0%) 79.9%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 89.05%
(+0%)
78.26%
(-1.45%)
85.71%
(+0%)
89.28%
(+0%)

@arboleya arboleya merged commit f75b673 into master Aug 12, 2024
20 checks passed
@arboleya arboleya deleted the aa/chore/adjusting-pr-tasklist branch August 12, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants