-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updating pull request tasklist #2910
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arboleya
requested review from
digorithm,
Torres-ssf,
Dhaiwat10,
danielbate,
nedsalk,
petertonysmith94 and
maschad
as code owners
August 11, 2024 18:50
arboleya
changed the title
Re-shaping template so all tasks can be completed
chore: updating pull request template
Aug 11, 2024
arboleya
changed the title
chore: updating pull request template
chore: updating pull request tasklist
Aug 11, 2024
petertonysmith94
previously approved these changes
Aug 12, 2024
danielbate
previously approved these changes
Aug 12, 2024
arboleya
commented
Aug 12, 2024
arboleya
dismissed stale reviews from danielbate and petertonysmith94
via
August 12, 2024 09:37
7d9eedf
danielbate
approved these changes
Aug 12, 2024
Dhaiwat10
approved these changes
Aug 12, 2024
petertonysmith94
approved these changes
Aug 12, 2024
Torres-ssf
approved these changes
Aug 12, 2024
maschad
approved these changes
Aug 12, 2024
Coverage Report:
Changed Files:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I considered re-wording the PR tasklist, so all items must always be ☑️ completed.
This way, all tasks must be completed for a PR to be ready, adding consistency and removing ambiguity.
The tasklist 👇 for this PR already follows the new model for demo purposes:
Checklist