-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use concurrency
to cancel previous CI runs
#361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Total Coverage: 88.71% Coverage Report
|
pedronauck
approved these changes
Jun 27, 2022
adlerjohn
approved these changes
Jun 27, 2022
@AlicanC can you also do this for our other repos? Good find. |
@adlerjohn, yup. Was planning to do that after seeing it work well here. |
This was referenced Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this SO page, it seems like the way we cancel previous runs is outdated and GitHub's native
concurrency
setting is the current practice: https://stackoverflow.com/questions/66335225/how-to-cancel-previous-runs-in-the-pr-when-you-push-new-commitsupdate-the-curreThe current GH action we use haven't been touched for two years and the alternatives looked similar.
This PR initially wasn't based on master and when I updated the branch, the previous run was successfully canceled as you can see on the run page:
Here, in
Test-361
,Test
is the name of the workflow, and361
is the number of this PR, which is what we would expect from ourgroup: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
setting.