Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use concurrency to cancel previous CI runs #361

Merged
merged 2 commits into from
Jun 27, 2022
Merged

Conversation

AlicanC
Copy link
Contributor

@AlicanC AlicanC commented Jun 27, 2022

From this SO page, it seems like the way we cancel previous runs is outdated and GitHub's native concurrency setting is the current practice: https://stackoverflow.com/questions/66335225/how-to-cancel-previous-runs-in-the-pr-when-you-push-new-commitsupdate-the-curre

The current GH action we use haven't been touched for two years and the alternatives looked similar.


This PR initially wasn't based on master and when I updated the branch, the previous run was successfully canceled as you can see on the run page:
image
Here, in Test-361, Test is the name of the workflow, and 361 is the number of this PR, which is what we would expect from our group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} setting.

@AlicanC AlicanC added the ci label Jun 27, 2022
@AlicanC AlicanC self-assigned this Jun 27, 2022
@github-actions
Copy link
Contributor

Total Coverage: 88.71%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
packages/abi-coder/src
   abi-coder.ts83.87%100%93.15%115, 116, 34, 34, 43, 50, 51, 53, 60, 61
   index.ts100%53.85%100%
   interface.ts73.08%90.91%90.32%111, 112, 130, 142, 142, 142, 144, 144, 145, 148, 42, 47, 90
   json-abi.ts50%100%100%35, 35, 35
   utilities.ts100%100%100%
packages/abi-coder/src/coders
   abstract-coder.ts100%100%87.50%46
   array.ts50%100%93.75%23, 24
   b256.ts66.67%100%94.12%31, 32
   boolean.ts60%100%82.35%17, 19, 20, 31, 32
   byte.ts50%100%94.12%29, 30
   enum.ts66.67%100%97.14%59, 60
   number.ts100%100%100%
   string.ts100%100%100%
   struct.ts100%100%100%
   tuple.ts100%100%100%
packages/abi-coder/src/fragments
   fragment.ts100%100%100%
   function-fragment.ts85.71%100%100%13
packages/constants/src
   index.ts100%100%100%
packages/contract/src
   contract-factory.ts40%66.67%76.47%31, 35, 36, 41, 44, 44, 44, 45, 46, 48, 49, 54, 58, 59
   contract.ts63.41%100%92.73%101, 102, 108, 109, 123, 124, 146, 147, 188, 189, 225, 226, 260, 261, 264, 307, 320, 324, 325, 373, 374, 392, 393, 41, 413, 414, 83
   index.ts100%100%100%
   scripts.ts78.57%100%94%35, 36, 85, 86, 88, 89
   util.ts100%60%64%19, 20, 21, 24, 25, 26, 27, 28, 31
packages/contract/src/multicall/out/debug
   multicall-bin.ts100%100%100%
packages/example-contract/src/example-contract-types
   index.ts100%100%100%
packages/example-contract/src/example-contract-types/factories
   ExampleContractAbi__factory.ts100%50%83.33%35
packages/fuels/src
   index.ts100%100%100%
packages/hasher/src
   hasher.ts87.50%100%97.37%43, 61
   index.ts100%100%100%
packages/hdwallet/src
   hdwallet-spec.ts100%100%100%
   hdwallet.ts80.39%100%95.96%127, 128, 190, 191, 22, 22, 229, 24, 26, 39, 42, 43, 96, 97
   index.ts100%100%100%
packages/interfaces/src
   index.ts100%100%91.67%36
packages/keystore/src
   aes-ctr-node.ts100%100%100%
   aes-ctr-web.ts100%0%24%15, 16, 17, 18, 19, 24, 25, 27, 39, 40, 41, 42, 44, 49, 51, 52, 54, 55, 57
   aes-ctr.ts80%75%72.22%19, 19, 20, 23, 26, 38
   index.ts100%100%100%
   keystore.ts50%75%100%17, 27
   randomBytes.ts50%100%100%4
   universal-crypto.ts83.33%100%72.73%15, 18, 19, 29
packages/math/src
   convert.ts66.67%100%85.71%28, 29, 37, 38, 43, 49, 49, 50, 54, 55
   index.ts100%100%100%
packages/merkle-shared/src
   common.ts100%100%100%
   cryptography.ts100%100%100%
   index.ts100%100%100%
packages/merkle/src
   binaryMerkleTree.ts71.43%100%97.01%110, 113, 72, 73
   index.ts100%100%100%
packages/merkle/src/types
   node.ts100%100%100%
packages/merklesum/src
   sumMerkleTree.ts83.33%100%97.01%128, 132, 133
packages/merklesum/src/types
   node.ts100%100%100%
   proof.ts100%100%100%
packages/mnemonic/src
   index.ts100%100%100%
   mnemonic-specs.ts100%100%100%
   mnemonic.ts80.95%100%96.08%141, 142, 157, 40, 41, 83
   utils.ts56.25%100%79.17%17, 20, 20, 20, 21, 22, 24, 24, 24, 24, 25, 29, 30, 31, 32, 33, 35, 36, 37, 58, 62, 63
packages/predicate/src
   predicate.ts73.68%100%98.04%150, 159, 30, 31, 80, 81
packages/predicate/src/test-predicate-address
   index.ts100%100%100%
packages/predicate/src/test-predicate-false
   index.ts100%100%100%
packages/predicate/src/test-predicate-struct
   index.ts100%100%100%
packages/predicate/src/test-predicate-true
   index.ts100%100%100%
packages/predicate/src/test-predicate-u32
   index.ts100%100%100%
packages/providers/src
   coin-quantity.ts83.33%100%100%19
   coin.ts100%0%100%
   index.ts100%100%100%
   provider.ts30%62.50%54.79%114, 124, 125, 177, 234, 234, 234, 235, 236, 236, 236, 237, 239, 242, 244, 244, 245, 248, 253, 265, 265, 265, 266, 267, 267, 267, 268, 270, 273, 275, 275, 276, 279, 284, 286, 295, 296, 296, 297, 299, 308, 309, 309, 310, 312, 45, 53
   util.ts0%0%20%10, 11, 14, 17, 21, 22, 22, 23, 33, 36, 37, 37, 37, 37, 37, 39, 46, 52, 60, 65, 69, 7, 71, 73, 8, 8, 8, 8
packages/providers/src/__generated__
   operations.ts100%58.33%78.49%1369, 1371, 1383, 1385, 1412, 1414, 1426, 1428, 1441, 1443, 1455, 1457, 1470, 1472, 1484, 1486, 1526, 1528, 1624, 1626
packages/providers/src/transaction-request
   index.ts100%100%100%
   input.ts77.78%100%90%35, 49, 69
   output.ts71.43%100%83.33%106, 57, 57, 75
   storage-slot.ts0%0%25%16, 17, 18, 25, 25, 25, 26, 27, 29, 30, 33
   transaction-request.ts62.12%60%73.08%104, 114, 126, 127, 128, 177, 178, 184, 185, 190, 191, 218, 220, 220, 221, 224, 251, 251, 252, 275, 318, 319, 331, 338, 339, 352, 353, 358, 359, 364, 365, 374, 413, 413, 414, 416, 430, 438, 439, 441, 447, 448, 456, 457, 463, 465, 492, 492, 497, 500, 66, 67, 71, 72, 73, 74, 79, 80, 81, 82
   witness.ts100%100%100%
packages/providers/src/transaction-response
   index.ts100%100%100%
   transaction-response.ts55.56%100%85.19%107, 107, 110, 131, 62, 70, 97, 98
packages/script/src
   errors.ts0%0%27.78%11, 11, 11, 14, 14, 14, 18, 19, 21, 21, 21, 24, 28, 29, 29, 29, 31, 31, 31, 34, 37, 37, 43, 44, 48, 49, 49, 50, 50
   index.ts100%100%100%
   script.ts28.57%66.67%77.14%114, 41, 42, 44, 45, 48, 49, 51, 52, 56, 86, 94, 95
   scripts.ts100%0%50%18, 19
packages/signer/src
   index.ts100%100%100%
   signer.ts75%100%97.30%32, 32, 34
packages/sparsemerkle/src
   deepSparseMerkleSubTree.ts66.67%60%75%13, 14, 20, 21, 37, 38
   proofs.ts63.64%100%85.11%25, 27, 27, 27, 28, 31, 32, 32, 34, 36, 37
   sparseMerkleTree.ts77.50%100%91.60%105, 106, 116, 118, 126, 128, 129, 131, 139, 139, 143, 144, 147, 161, 162, 277, 280, 98, 99
   treeHasher.ts100%100%100%
   utils.ts100%100%100%
packages/sparsemerkle/src/types
   sparseCompactMerkleProof.ts100%100%100%
   sparseMerkleProof.ts100%100%100%
packages/transactions/src
   consts.ts100%100%100%
   index.ts100%100%100%
packages/transactions/src/coders
   byte-array.ts100%100%100%
   input.ts75%100%97.53%174, 184, 197, 207
   output.ts87.50%100%98.48%316, 342, 355, 381
   receipt.ts87.50%97.06%97.27%627, 629, 630, 632, 676, 676, 714, 715, 718, 731, 773
   storage-slot.ts100%100%100%
   transaction.ts75%100%98.55%304, 314, 327, 337
   utxo-id.ts100%100%100%
   witness.ts100%100%100%
packages/typechain-target-fuels/src/codegen
   types.ts69.77%60%63.27%102, 102, 102, 128, 130, 132, 18, 18, 19, 22, 24, 24, 24, 34, 36, 36, 39, 39, 40, 42, 45, 47, 47, 48, 51, 59, 59, 84, 86, 98, 99
packages/typechain-target-fuels/src/parser
   abiParser.ts36.11%85.71%58.73%128, 172, 173, 181, 182, 204, 205, 205, 215, 216, 218, 221, 221, 222, 225, 225, 226, 229, 229, 230, 232, 232, 232, 232, 233, 236, 243, 244, 246, 249, 249, 249, 249, 249, 251, 251, 251, 254, 254, 255, 256, 256, 257, 257, 257, 258, 259, 259, 262
   parseSvmTypes.ts50%100%85.37%111, 112, 148, 159, 159, 159, 159, 159, 163, 169, 171, 175, 177, 182, 187
packages/wallet-manager/src
   wallet-manager-spec.ts100%100%100%
   wallet-manager.ts100%100%100%
packages/wallet-manager/src/storages
   memory-storage.ts100%100%100%
packages/wallet-manager/src/vaults
   mnemonic-vault.ts85.71%100%93.33%20, 70, 73
   privatekey-vault.ts60%100%95%23, 56, 57
packages/wallet/src
   index.ts100%100%100%
   test-utils.ts66.67%100%100%8
   wallet-spec.ts100%100%100%
   wallet.ts73.33%95.24%93.90%133, 142, 143, 144, 170, 195, 270, 57, 58
packages/wordlists/src
   index.ts100%100%100%
packages/wordlists/src/words
   english.ts100%100%100%

@AlicanC AlicanC requested review from LuizAsFight, pedronauck and a team June 27, 2022 15:23
@AlicanC AlicanC marked this pull request as ready for review June 27, 2022 15:23
@adlerjohn
Copy link
Contributor

@AlicanC can you also do this for our other repos? Good find.

@AlicanC
Copy link
Contributor Author

AlicanC commented Jun 27, 2022

@adlerjohn, yup. Was planning to do that after seeing it work well here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants