Update err message to handle failed download #48
Conversation
fuelup-init.sh
Outdated
| if echo "$_err" | grep -q 404$; then | ||
| err "installer for platform '$3' not found, this may be unsupported" | ||
| if echo "$_err" | grep -q 404; then | ||
| err "fuelup was not found - either the release is not ready yet or the tag is invalid. You can check if the release is available here: https://github.com/FuelLabs/fuelup/releases" |
There was a problem hiding this comment.
Looks it like was erroneously changed from spaces to tabs?
There was a problem hiding this comment.
are spaces preferred here? I ran it all under a shell formatter one of the last PRs. Can we disregard this indentation issue this PR and I will open another PR running shfmt? Would probably be worth including in #31 as well
fuelup-init.sh
Outdated
| if echo "$_err" | grep -q 404$; then | ||
| err "installer for platform '$3' not found, this may be unsupported" | ||
| if echo "$_err" | grep -q 404; then | ||
| err "fuelup was not found - either the release is not ready yet or the tag is invalid. You can check if the release is available here: https://github.com/FuelLabs/fuelup/releases" |
There was a problem hiding this comment.
Link to the actual release that's being tried
There was a problem hiding this comment.
Hmm, I linked to the releases page as a conscious decision since linking to a version that doesn't exist results simply in a Github 404 page, which isn't very informative (imo). Linking to the releases page allows the user to look at the latest release from the top anyway, and to manually check if the version the script was trying to download exists.
With that said, will update it to link to the actual release though - if the above logic makes sense I can change it back in future
There was a problem hiding this comment.
Unless something goes very wrong, the only time this error should be hit under normal operation is when there's a release but not binaries uploaded yet. So not a 404. If it's a 404 then that means something went really wrong, for which linking to the exact page is probably more informative.
Closes #44
_fuelup_versionto the info printed, so that users can check versioning at the release pageget_architecturealready$matching ingrep- i'm not sure why matching$didn't work on my machine, but matching404should be sufficient either way since there would be nowhere else in the message that should have a404