-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full test coverage for the basic section of the Multisig functionality #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Braqzen
added
New Feature
New addition that does not currently exist
Good First Issue
Good for newcomers
Awaiting Sway feature(s)
Language does not support desired functionality, yet
labels
Jun 22, 2022
Braqzen
requested review from
adlerjohn,
nfurfaro,
SwayStar123,
matt-user,
bitzoic and
rostyslavtyshko
June 22, 2022 10:20
Braqzen
changed the title
Full test coverage for Basic functionality
Full test coverage for the basic section of the Multisig functionality
Jun 22, 2022
nfurfaro
reviewed
Jun 24, 2022
simonr0204
added
the
Awaiting SDK feature(s)
SDK does not support desired functionality, yet
label
Aug 23, 2022
This PR can be closed once #272 is merged, as it includes the addition of full test coverage for the Multisig-wallet. |
simonr0204
removed
Awaiting Sway feature(s)
Language does not support desired functionality, yet
Awaiting SDK feature(s)
SDK does not support desired functionality, yet
labels
Dec 9, 2022
If the other PR includes the changes, then this one will never be merged, right? We should close it, if that's the case. |
Correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
App: Multisig
Label used to filter for the app issue
Good First Issue
Good for newcomers
New Feature
New addition that does not currently exist
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Changes
The following changes have been made:
Notes
Related Issues
Closes #7