Multisig-wallet ETH signature support #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted predicate with derived pub key
…cations into eth-account-abstraction
…cations into eth-account-abstraction
…e.rs Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com>
…cations into eth-account-abstraction
Braqzen
previously approved these changes
Jan 11, 2023
multisig-wallet/project/multisig-contract/src/data_structures.sw
Outdated
Show resolved
Hide resolved
multisig-wallet/project/multisig-contract/tests/functions/cancel_transaction.rs
Show resolved
Hide resolved
matt-user
reviewed
Jan 17, 2023
Braqzen
approved these changes
Jan 17, 2023
simonr0204
approved these changes
Jan 19, 2023
simonr0204
dismissed
matt-user’s stale review
This is ready to merge now, so dismissing as requested change (addressed) is blocking.
This was referenced Jan 19, 2023
Closed
Closed
bitzoic
added a commit
that referenced
this pull request
Feb 2, 2023
* chore: add version tag to deps (#361) (#362) * Fundraiser code quality and testing (#322) * Multisig-wallet ETH signature support (#272) * eth-account-abstraction; added initial predicate * eth-account-abstraction; updated predicate to use public key * eth-account-abstraction; added script for pub key derivation and updated predicate with derived pub key * eth-account-abstraction; swicthed to using addresses * eth-account-abstraction; basic ec_recover functionaliy * eth-account-abstraction; cleaned up * eth-account-abstraction; added panicking test * eth-account-abstraction; add eth_prefix util * eth-account-abstraction; added eip_191_hash util * eth-account-abstraction; added ec_recover_evm_address util * Added recover.sw and associated test for debugging ec recovery * Synced with master * Updated cargo.toml for linting * Updated cargo.toml for linting * Added test for debugging with sway script * Setup for EVM address * Renamed recover script * Setup for verifying address hashing in Sway * Setup testing ec_recover from known valid signature * Setup for testing Secretkey creation via different methods * Setup for testing signature creation methods * Cleaned up testing signature creation methods * Setup for working with correct values via sign_compact_recoverable * Updated reference/target values * Cleaned up; setup for recovery of evm address * Updated to forc 0.30 and fuels 0.28 * Updated to use SDK's sign_message * Added panicing test * Updated eip_191_format and added utils as dep * Added sha3 as dependency * Setup for testing inputs of hashing during eip-191 formatting * Setup for comparison of bit-shifted data * Updated to new compose & decompose functions * Setup for testing eip-191 formatting, with temp padded data * Updated encode_data docs * Setup for testing single signature, with EIP-191(padded) and Eth-prefix, recovery * Updated signing mechanism and refactored test utils * Single signature, with EIP-191 format and Eth-prefix, recovery * forc-fmt * fmt * Switched to contract to test updated count_approval function * Multi-sig style account abstracted signature recovery * Refactored utils * Resolved errors from forc updates * Updated constructor * Updated execute_transaction * Updated transfer * Removed is_owner * Updated transaction_hash * Updated nonce * Updated create_hash * Added account abstracted count_approvals functionality * Updated interface imports * Renamed to interface * Updated documentation * Refactored utils * Removed pub from count_approvals * Multi-Sig setup for basic account abstraction test * Updated forc and fuels versions * Refactor: transfer * Setup for basic full transfer test * Refactor: tests/utils/mod.rs and cleared up docs * Removed unused imports * Added abi calls * Added test_helpers * Added deps * Refactored encode_data * Setup full testing format * Added function testing * Added gets_transaction_hash test * Refactored create_hash * Removed unused imports and fixed signature variable definition * Refactored gets_transaction_hash * Removed eth-account-abstraction dir * Removed unused deps * Refactored multisig-wallet dir ahead of merge * CI; update forc * Updated in-code docs * Updated README * Refactored for contributing book code style compliance * Update multisig-wallet/project/multisig-contract/src/data_structures.sw Co-authored-by: Matt <54373384+matt-user@users.noreply.github.com> * Update multisig-wallet/project/multisig-contract/src/interface.sw Co-authored-by: Matt <54373384+matt-user@users.noreply.github.com> * Update multisig-wallet/project/multisig-contract/src/main.sw Co-authored-by: Matt <54373384+matt-user@users.noreply.github.com> * Update multisig-wallet/project/multisig-contract/src/main.sw Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Update multisig-wallet/project/multisig-contract/src/main.sw Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Update multisig-wallet/project/multisig-contract/src/interface.sw Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Update multisig-wallet/project/multisig-contract/src/utils.sw Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Update multisig-wallet/project/multisig-contract/src/utils.sw Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Fixed grammar * Refactored SignatueData and added field docs * Updated constructor docs * Refactored SignatureData within format_and_sign * Removed imports already contained within prelude * Refactored single imports * CI: Forc.toml * Docs: replaced Panics with Reverts * Refactored comments and removed unneeded comments * Reworder SignaturData docs * Renamed SignatureData fields * Renamed SignatureData => SignatureInfo * Renamed signatures_data => signatures and signature_data => signature_info * Swicthed to backticks * Ordered event fields * Refactored User docs * Added check in constructor for threshold <= sum of weights * recover_signer; use propagated error from ec_recover_address * Added link to EIP-191 and EIP-191 constants * Renamed encode_and_pack_signed_data and refactored eip_191_personal_sign_format * Added cancel_transaction * Refactored utils * Ethereum Prefix now uses Keccak256 * Updated ethereum_prefix docs * Refactored tests with utility parameters * Refactored revert module into alphabetical order * Added paths module * Added TODO regarding use of unsafe blocks * Added EIP-191 info to README * Added specification and sequence diagram * Added template tests for execute_transaction * Bumped versions and refactored utils * Refactored utils and added comment * Bump in line with repo * Removed redundent headings * Added suggested assertion to balance test * Update multisig-wallet/project/multisig-contract/tests/functions/cancel_transaction.rs Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Reordered tests * Added suggestion to constructor test * Added should panic errors * Update multisig-wallet/project/multisig-contract/tests/functions/nonce.rs Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Updated test assertions * Removed redundant transfer * Renamed constructor_users to defaul_users * Updated Bytes ToDos * Renamed contract binding type * Refactored * Renamed abi_calls to interface * Added testing for logs Co-authored-by: Matt <54373384+matt-user@users.noreply.github.com> Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Timelock Smart Contract (#338) * Remove an outdated comment from the Timelock contract * Bump repo (#364) * Contributing Book: Improve Testing Page (#368) * AMM utils & contract logs (#365) * Tic-Tac-Toe application (#157) * changed - to * refs #392 (#393) * Fix broken links in sway-applications NFT docs (#387) Co-authored-by: Cameron Carstens <54727135+bitzoic@users.noreply.github.com> --------- Co-authored-by: Matt <54373384+matt-user@users.noreply.github.com> Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> Co-authored-by: K1-R1 <77465250+K1-R1@users.noreply.github.com> Co-authored-by: Kaiser Sakhi <31089012+kaisersakhi@users.noreply.github.com> Co-authored-by: Bikem <bengisuozaydin@gmail.com> Co-authored-by: Ruben Amar <43066067+Rubyt0x@users.noreply.github.com> Co-authored-by: haadfida <haad99@gmail.com> Co-authored-by: Michael Hamilton Paler <mpaler@users.noreply.github.com> Co-authored-by: bitzoic <cameron.carstens@fuel.sh>
bitzoic
added a commit
that referenced
this pull request
Feb 2, 2023
* chore: add version tag to deps (#361) (#362) * Fundraiser code quality and testing (#322) * Multisig-wallet ETH signature support (#272) * eth-account-abstraction; added initial predicate * eth-account-abstraction; updated predicate to use public key * eth-account-abstraction; added script for pub key derivation and updated predicate with derived pub key * eth-account-abstraction; swicthed to using addresses * eth-account-abstraction; basic ec_recover functionaliy * eth-account-abstraction; cleaned up * eth-account-abstraction; added panicking test * eth-account-abstraction; add eth_prefix util * eth-account-abstraction; added eip_191_hash util * eth-account-abstraction; added ec_recover_evm_address util * Added recover.sw and associated test for debugging ec recovery * Synced with master * Updated cargo.toml for linting * Updated cargo.toml for linting * Added test for debugging with sway script * Setup for EVM address * Renamed recover script * Setup for verifying address hashing in Sway * Setup testing ec_recover from known valid signature * Setup for testing Secretkey creation via different methods * Setup for testing signature creation methods * Cleaned up testing signature creation methods * Setup for working with correct values via sign_compact_recoverable * Updated reference/target values * Cleaned up; setup for recovery of evm address * Updated to forc 0.30 and fuels 0.28 * Updated to use SDK's sign_message * Added panicing test * Updated eip_191_format and added utils as dep * Added sha3 as dependency * Setup for testing inputs of hashing during eip-191 formatting * Setup for comparison of bit-shifted data * Updated to new compose & decompose functions * Setup for testing eip-191 formatting, with temp padded data * Updated encode_data docs * Setup for testing single signature, with EIP-191(padded) and Eth-prefix, recovery * Updated signing mechanism and refactored test utils * Single signature, with EIP-191 format and Eth-prefix, recovery * forc-fmt * fmt * Switched to contract to test updated count_approval function * Multi-sig style account abstracted signature recovery * Refactored utils * Resolved errors from forc updates * Updated constructor * Updated execute_transaction * Updated transfer * Removed is_owner * Updated transaction_hash * Updated nonce * Updated create_hash * Added account abstracted count_approvals functionality * Updated interface imports * Renamed to interface * Updated documentation * Refactored utils * Removed pub from count_approvals * Multi-Sig setup for basic account abstraction test * Updated forc and fuels versions * Refactor: transfer * Setup for basic full transfer test * Refactor: tests/utils/mod.rs and cleared up docs * Removed unused imports * Added abi calls * Added test_helpers * Added deps * Refactored encode_data * Setup full testing format * Added function testing * Added gets_transaction_hash test * Refactored create_hash * Removed unused imports and fixed signature variable definition * Refactored gets_transaction_hash * Removed eth-account-abstraction dir * Removed unused deps * Refactored multisig-wallet dir ahead of merge * CI; update forc * Updated in-code docs * Updated README * Refactored for contributing book code style compliance * Update multisig-wallet/project/multisig-contract/src/data_structures.sw Co-authored-by: Matt <54373384+matt-user@users.noreply.github.com> * Update multisig-wallet/project/multisig-contract/src/interface.sw Co-authored-by: Matt <54373384+matt-user@users.noreply.github.com> * Update multisig-wallet/project/multisig-contract/src/main.sw Co-authored-by: Matt <54373384+matt-user@users.noreply.github.com> * Update multisig-wallet/project/multisig-contract/src/main.sw Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Update multisig-wallet/project/multisig-contract/src/main.sw Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Update multisig-wallet/project/multisig-contract/src/interface.sw Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Update multisig-wallet/project/multisig-contract/src/utils.sw Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Update multisig-wallet/project/multisig-contract/src/utils.sw Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Fixed grammar * Refactored SignatueData and added field docs * Updated constructor docs * Refactored SignatureData within format_and_sign * Removed imports already contained within prelude * Refactored single imports * CI: Forc.toml * Docs: replaced Panics with Reverts * Refactored comments and removed unneeded comments * Reworder SignaturData docs * Renamed SignatureData fields * Renamed SignatureData => SignatureInfo * Renamed signatures_data => signatures and signature_data => signature_info * Swicthed to backticks * Ordered event fields * Refactored User docs * Added check in constructor for threshold <= sum of weights * recover_signer; use propagated error from ec_recover_address * Added link to EIP-191 and EIP-191 constants * Renamed encode_and_pack_signed_data and refactored eip_191_personal_sign_format * Added cancel_transaction * Refactored utils * Ethereum Prefix now uses Keccak256 * Updated ethereum_prefix docs * Refactored tests with utility parameters * Refactored revert module into alphabetical order * Added paths module * Added TODO regarding use of unsafe blocks * Added EIP-191 info to README * Added specification and sequence diagram * Added template tests for execute_transaction * Bumped versions and refactored utils * Refactored utils and added comment * Bump in line with repo * Removed redundent headings * Added suggested assertion to balance test * Update multisig-wallet/project/multisig-contract/tests/functions/cancel_transaction.rs Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Reordered tests * Added suggestion to constructor test * Added should panic errors * Update multisig-wallet/project/multisig-contract/tests/functions/nonce.rs Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Updated test assertions * Removed redundant transfer * Renamed constructor_users to defaul_users * Updated Bytes ToDos * Renamed contract binding type * Refactored * Renamed abi_calls to interface * Added testing for logs Co-authored-by: Matt <54373384+matt-user@users.noreply.github.com> Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Timelock Smart Contract (#338) * Remove an outdated comment from the Timelock contract * Bump repo (#364) * Contributing Book: Improve Testing Page (#368) * AMM utils & contract logs (#365) * Tic-Tac-Toe application (#157) * changed - to * refs #392 (#393) * Fix broken links in sway-applications NFT docs (#387) Co-authored-by: Cameron Carstens <54727135+bitzoic@users.noreply.github.com> * Update add ignored tests and update to use LEAF and NODE * Update to use latest release of sway-libs * Resolve merge conflicts --------- Co-authored-by: Matt <54373384+matt-user@users.noreply.github.com> Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> Co-authored-by: K1-R1 <77465250+K1-R1@users.noreply.github.com> Co-authored-by: Kaiser Sakhi <31089012+kaisersakhi@users.noreply.github.com> Co-authored-by: Bikem <bengisuozaydin@gmail.com> Co-authored-by: Ruben Amar <43066067+Rubyt0x@users.noreply.github.com> Co-authored-by: haadfida <haad99@gmail.com> Co-authored-by: Michael Hamilton Paler <mpaler@users.noreply.github.com> Co-authored-by: bitzoic <cameron.carstens@fuel.sh>
bitzoic
added a commit
that referenced
this pull request
Feb 24, 2023
* chore: add version tag to deps (#361) (#362) * Fundraiser code quality and testing (#322) * Multisig-wallet ETH signature support (#272) * eth-account-abstraction; added initial predicate * eth-account-abstraction; updated predicate to use public key * eth-account-abstraction; added script for pub key derivation and updated predicate with derived pub key * eth-account-abstraction; swicthed to using addresses * eth-account-abstraction; basic ec_recover functionaliy * eth-account-abstraction; cleaned up * eth-account-abstraction; added panicking test * eth-account-abstraction; add eth_prefix util * eth-account-abstraction; added eip_191_hash util * eth-account-abstraction; added ec_recover_evm_address util * Added recover.sw and associated test for debugging ec recovery * Synced with master * Updated cargo.toml for linting * Updated cargo.toml for linting * Added test for debugging with sway script * Setup for EVM address * Renamed recover script * Setup for verifying address hashing in Sway * Setup testing ec_recover from known valid signature * Setup for testing Secretkey creation via different methods * Setup for testing signature creation methods * Cleaned up testing signature creation methods * Setup for working with correct values via sign_compact_recoverable * Updated reference/target values * Cleaned up; setup for recovery of evm address * Updated to forc 0.30 and fuels 0.28 * Updated to use SDK's sign_message * Added panicing test * Updated eip_191_format and added utils as dep * Added sha3 as dependency * Setup for testing inputs of hashing during eip-191 formatting * Setup for comparison of bit-shifted data * Updated to new compose & decompose functions * Setup for testing eip-191 formatting, with temp padded data * Updated encode_data docs * Setup for testing single signature, with EIP-191(padded) and Eth-prefix, recovery * Updated signing mechanism and refactored test utils * Single signature, with EIP-191 format and Eth-prefix, recovery * forc-fmt * fmt * Switched to contract to test updated count_approval function * Multi-sig style account abstracted signature recovery * Refactored utils * Resolved errors from forc updates * Updated constructor * Updated execute_transaction * Updated transfer * Removed is_owner * Updated transaction_hash * Updated nonce * Updated create_hash * Added account abstracted count_approvals functionality * Updated interface imports * Renamed to interface * Updated documentation * Refactored utils * Removed pub from count_approvals * Multi-Sig setup for basic account abstraction test * Updated forc and fuels versions * Refactor: transfer * Setup for basic full transfer test * Refactor: tests/utils/mod.rs and cleared up docs * Removed unused imports * Added abi calls * Added test_helpers * Added deps * Refactored encode_data * Setup full testing format * Added function testing * Added gets_transaction_hash test * Refactored create_hash * Removed unused imports and fixed signature variable definition * Refactored gets_transaction_hash * Removed eth-account-abstraction dir * Removed unused deps * Refactored multisig-wallet dir ahead of merge * CI; update forc * Updated in-code docs * Updated README * Refactored for contributing book code style compliance * Update multisig-wallet/project/multisig-contract/src/data_structures.sw Co-authored-by: Matt <54373384+matt-user@users.noreply.github.com> * Update multisig-wallet/project/multisig-contract/src/interface.sw Co-authored-by: Matt <54373384+matt-user@users.noreply.github.com> * Update multisig-wallet/project/multisig-contract/src/main.sw Co-authored-by: Matt <54373384+matt-user@users.noreply.github.com> * Update multisig-wallet/project/multisig-contract/src/main.sw Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Update multisig-wallet/project/multisig-contract/src/main.sw Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Update multisig-wallet/project/multisig-contract/src/interface.sw Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Update multisig-wallet/project/multisig-contract/src/utils.sw Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Update multisig-wallet/project/multisig-contract/src/utils.sw Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Fixed grammar * Refactored SignatueData and added field docs * Updated constructor docs * Refactored SignatureData within format_and_sign * Removed imports already contained within prelude * Refactored single imports * CI: Forc.toml * Docs: replaced Panics with Reverts * Refactored comments and removed unneeded comments * Reworder SignaturData docs * Renamed SignatureData fields * Renamed SignatureData => SignatureInfo * Renamed signatures_data => signatures and signature_data => signature_info * Swicthed to backticks * Ordered event fields * Refactored User docs * Added check in constructor for threshold <= sum of weights * recover_signer; use propagated error from ec_recover_address * Added link to EIP-191 and EIP-191 constants * Renamed encode_and_pack_signed_data and refactored eip_191_personal_sign_format * Added cancel_transaction * Refactored utils * Ethereum Prefix now uses Keccak256 * Updated ethereum_prefix docs * Refactored tests with utility parameters * Refactored revert module into alphabetical order * Added paths module * Added TODO regarding use of unsafe blocks * Added EIP-191 info to README * Added specification and sequence diagram * Added template tests for execute_transaction * Bumped versions and refactored utils * Refactored utils and added comment * Bump in line with repo * Removed redundent headings * Added suggested assertion to balance test * Update multisig-wallet/project/multisig-contract/tests/functions/cancel_transaction.rs Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Reordered tests * Added suggestion to constructor test * Added should panic errors * Update multisig-wallet/project/multisig-contract/tests/functions/nonce.rs Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Updated test assertions * Removed redundant transfer * Renamed constructor_users to defaul_users * Updated Bytes ToDos * Renamed contract binding type * Refactored * Renamed abi_calls to interface * Added testing for logs Co-authored-by: Matt <54373384+matt-user@users.noreply.github.com> Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> * Timelock Smart Contract (#338) * Remove an outdated comment from the Timelock contract * Bump repo (#364) * Contributing Book: Improve Testing Page (#368) * AMM utils & contract logs (#365) * Tic-Tac-Toe application (#157) * changed - to * refs #392 (#393) * Fix broken links in sway-applications NFT docs (#387) Co-authored-by: Cameron Carstens <54727135+bitzoic@users.noreply.github.com> * Pin `forc` and `fuel-core` versions in `fuel-toolchain.toml` (#377) * Fix CI (#406) * CI test * `cd` before `forc` commands * AMM correct versions * Removed StorageMap (#459) * OTC: unnecessary pub keyword * Fix build.sh devops script * AMM: Remove `ExpectedZeroAmount` error and relevant test (#402) * Restructure applications in preparation for user interfaces (#409) * New devops script to bump the fuel-toolchain.toml (#467) * Scaffolding tool for frontends (#394) * Factor out apps in .devops scripts into a single location * remove `Forc.toml` (#488) * update path (#490) * fix typo (#492) * UI scaffold: move `hooks` and `utils` into `src` (#496) * UI scaffold: Convert `echo`s to `printf`s (#497) * remove fuels prelude global imports (#501) * AMM: test emitted logs (#502) * Bump: AMM (#500) * TicTacToe: remove `identity` function from tests * TicTacToe: change `fuels::prelude::*` to be explicit * Fundraiser: change `fuels::prelude::*` to be explicit * Bump: OTC (#521) * F-NFT: Fix readme path link to specification * OTC Swap Predicate: Remove transaction building workaround (#544) * DAO: Split the abi into core and info * Bump: Oracle * Fix `.devops/bump_toolchain.sh` (#508) * Workaround: Merge Multisig into master * Oracle: test emitted logs * .devops script to format sway and rust code * F-NFT: Split the abi into core and info (#545) * bumped ci (#558) * English Auction: Split the abi into core and info * Name-Registry: Split the abi into core and info * Airdrop: test emitted logs (#524) * NFT: test emitted logs (#525) * DAO: test emitted logs (#522) * Escrow: test emitted logs (#523) * Bump: Airdrop (#516) * Airdrop: Split the abi into core and info (#540) * Bump: Escrow (#513) * Add information about the fuel-toolchain.toml files (#514) * Resolve merge conflicts * Remove merge conflict resolutions * Even MORE merge conflict resolutions --------- Co-authored-by: Matt <54373384+matt-user@users.noreply.github.com> Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com> Co-authored-by: K1-R1 <77465250+K1-R1@users.noreply.github.com> Co-authored-by: Kaiser Sakhi <31089012+kaisersakhi@users.noreply.github.com> Co-authored-by: Bikem <bengisuozaydin@gmail.com> Co-authored-by: Ruben Amar <43066067+Rubyt0x@users.noreply.github.com> Co-authored-by: haadfida <haad99@gmail.com> Co-authored-by: Michael Hamilton Paler <mpaler@users.noreply.github.com> Co-authored-by: Kirito <74639234+Kirito-Excalibur@users.noreply.github.com> Co-authored-by: Tarun Samanta <55488549+tarunsamanta2k20@users.noreply.github.com> Co-authored-by: GeckoSplat <111183176+GeckoSplat@users.noreply.github.com> Co-authored-by: bitzoic <cameron.carstens@fuel.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Changes
Related Issues
Closes #10