Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nightly releases #1616

Closed
eightfilms opened this issue May 20, 2022 · 9 comments
Closed

Support nightly releases #1616

eightfilms opened this issue May 20, 2022 · 9 comments

Comments

@eightfilms
Copy link
Contributor

In a recent chat with @mitchmindtree, we discussed how it might be a good time to consider supporting nightly releases in the near future, especially with fuelup in the works. Justification is that Fuel devs would be able to easily grab the most recent changes without having to manually clone, build and install all the tools.

Seems like we already have a nightly cargo audit CI job - we can further extend this to support nightly releases for our binaries

@adlerjohn
Copy link
Contributor

Fun fact but we used to have https://github.com/FuelLabs/sway-nightly-binaries. Time to revive that repo?

@eightfilms
Copy link
Contributor Author

Previously it seems like we had nightly releases implemented in the format stated here #175

Proposing to use nightly-YYYYMMDD-hash instead (without the hours). Happy to pick this up once myself once we agree on a format for forc and fuel-core releases
FuelLabs/fuel-core#503 (comment)

@mitchmindtree
Copy link
Contributor

@bingcicle SGTM!

@eightfilms
Copy link
Contributor Author

Fun fact but we used to have https://github.com/FuelLabs/sway-nightly-binaries. Time to revive that repo?

Question about releasing nightlies - I think we should revive this repo and release binary assets there instead of within this repo, so that we do not pollute the releases under this repo. The CI yaml will be vastly different as well since we can skip most of the CI steps and go straight to building and releasing, so I think it's fair to have a different repo and workflow for this.

@adlerjohn
Copy link
Contributor

Un-archived the repo. Feel free to nuke the default branch's current contents and use it at will.

@eightfilms
Copy link
Contributor Author

Will also create a fuel-core-nightly as well - will mention this in the fuel-core issue

@eightfilms
Copy link
Contributor Author

Ah wait, is this something we want^? Or do we want both in the same repo?

@adlerjohn
Copy link
Contributor

Up to you. For this, I'm not necessarily sure what the benefit of two repos is.

@eightfilms
Copy link
Contributor Author

Nightlies are live on https://github.com/FuelLabs/sway-nightly-binaries along with their respective workflows. Did this because the workflows are significant shorter (no testing, since commits to master would've already passed the CI steps anyway) + includes extra steps to create releases.

Can we also add protection rules to that repo? @adlerjohn

I think this issue can be closed once we resolve the above

@sdankel sdankel closed this as completed Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants