-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduces initial draft of nightly binary publishing #175
Conversation
1afeb2f
to
b6f01d9
Compare
CI failing |
de7f042
to
cd79685
Compare
Whoops. Fixed now. And here's the first release: https://github.com/FuelLabs/sway-nightly-binaries Only the sway server in that one but the rest will have |
cd79685
to
b47cb7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Two things:
- Probably want to use time down to the seconds, to avoid multiple commits on the same day being out of order.
- Can you also compile for arm64, and make separate directories for different archs?
Sounds good. How about these for now?
I think that's enough for now, unless you want to support riscv or mips...or power pc... |
I think we can omit Windows for now since we don't really have any way of testing it. If devs want it we can add it to our pipeline. The rest are fine. |
b47cb7b
to
c7e422e
Compare
Sorry for all those subscribed to this issue. The Edit: Apparently it went through even though it 404'd. Whatever. |
f58d572
to
90dcfad
Compare
72cc5ef
to
cfdaf37
Compare
9f01b41
to
6da5c98
Compare
Closes #79
See the deploy for this PR here: https://github.com/FuelLabs/sway-nightly-binaries/tree/master/nightly-2021-08-26:16:34:12-9f01b41
Summary
This PR builds x86 MacOS and x86 Linux images, makes a new folder of the format
nightly-$DATETIME-$SHORT_SHA
, and uploadssway-server
andforc
to subdirectories corresponding to the build arch on every push tomaster
.Other Notes
Some of our crates unfortunately do not support cross compilation. Because of this, we can only compile for targets that Github has runners for. This page has the available options for Github-hosted runners. Unless Github introduces an ARM runner, or we self host our own runners, we can only build x86 targets for now.
This PR builds and deploys x86 MacOS images and x86 Linux images. It would also be easy to add Windows, if we wanted, since Github has a runner for it. That being said, I'm not sure we want to sign up for supporting Windows.
I propose as a temporary work-around that we manually upload ARM/M1 images as needed when consumers want them. I can run the builds myself and upload them to the nightlies repo.
I also changed the cargo test stage so that it only runs if you change any
.rs
,.sw
, or.toml
files. I thought that might save us some minutes when editing yaml files and stuff.