Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider workspace path to source patch declarations declared in workspace manifest file #4596

Open
kayagokalp opened this issue May 29, 2023 · 0 comments
Open

Consider workspace path to source patch declarations declared in workspace manifest file #4596

kayagokalp opened this issue May 29, 2023 · 0 comments
Assignees
@kayagokalp
Labels
bug Something isn't working forc-pkg Everything related to the `forc-pkg` crate.

Comments

@kayagokalp
Copy link
Member

Realized while fixing #4595. I tried to use our handy workspace patch table feature to fix the problem realized it was not working. The problem seems like it tries to source the patch dependency from the member's path instead of workspace's path. This only happens with path based patch declarations done in workspace level.
@kayagokalp kayagokalp added bug Something isn't working forc-pkg Everything related to the `forc-pkg` crate. labels May 29, 2023
@kayagokalp kayagokalp self-assigned this May 29, 2023
This was referenced May 29, 2023
Merged
Closed
kayagokalp added a commit that referenced this issue May 29, 2023
@kayagokalp
ci-fix: use latest (sourced via path) version of std while testing sw…
8844b4f 
…ay reference examples (#4597)

## Description

closes #4595.
unblocks #4525.

Once #4596 is fixed we can remove std declarations in each manifest file
with a single patch statement in the workspace level manifest file. That
will also open the way to re-enable the disabled member (reentrancy) as
the example depends on sway-lib and sway-lib depends on latest released
std. So without the patch table it is not useable.

follow-up: #4596.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kayagokalp kayagokalp

Labels
bug Something isn't working forc-pkg Everything related to the `forc-pkg` crate.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use workspace's dir path for sourcing workspace level patch declarations FuelLabs/sway
1 participant
@kayagokalp