Upgrade to fuel-core 0.18.1 and fuels-rs 0.41
#4525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applied latest `fuels-rs`. Fixed compilation errors.
|
this one supersedes #4428 |
7 tasks
Update CI to use 0.18.0 image
…ture/fuel-core-0.18
xgreenx
commented
May 3, 2023
xgreenx
requested review from
nfurfaro,
mitchmindtree and
AlicanC
and removed request for
nfurfaro
kayagokalp
previously approved these changes
May 3, 2023
xgreenx
changed the title
fuel-core 0.18.0 and fuels-rs 0.41fuel-core 0.18.1 and fuels-rs 0.41
sdankel
previously approved these changes
May 4, 2023
sway-core/src/semantic_analysis/ast_node/expression/intrinsic_function.rs
Show resolved
Hide resolved
7 tasks
iqdecay
added a commit
to FuelLabs/fuels-rs
that referenced
this pull request
May 25, 2023
BREAKING CHANGES: - `Predicate::from_code` and `Predicate::load_from` use default `ConsensusParameters` for instantiation of the predicate address. To use non-default `ConsensusParameters`, the user should use `Predicate::from_code(...).with_provider()`, that will use the provider's `ConsensusParameters`. - `Provider::new` now takes a `ConsensusParameters` argument, so we can avoid changing the API of downstream clients. - `setup_test_client` now returns `ConsensusParameters` of the client. It is less used than `setup_test_provider` so it's its API that was changed. - `produce_block` API now takes in a `start_time` as an `Option<DateTime<Utc>>` (no need for the `TimeParameters` struct) - To produce blocks, the user now needs to set `block_production` to `Trigger::Interval` (see docs) in `ChainConfig` Internal changes: - The signing of the transaction and predicate id generation requires `ChainId`(`ConsensusParameters`). - Now tokens should be transferred to the contract first, and after you can transfer them via `SMO` or another transfer. So in some tests first we need to transfer money to the contract first. - Replaced all unsafe code from `fuel-crypto` with safe analog. - On the `fuel-tx`/`fuel-core` side now, there is a difference in whether the message contains data. If data is empty, it is `MessageCoin` that acts like a `Coin`(has the same rules during execution). If the data field is not empty, then it is a retryable message(or `MessageData`). Messages like this can't be used to pay a transaction fee, and if the execution fails, the message is not consumed(you can use it again in the next transactions). More about them you can read in FuelLabs/fuel-core#946. Also, the API changed for resources and not it is `Coins` again. Because of that, some tests now require messages with empty data to be able to spend them. - Removed redundant usage of `MessageId`. Now the identifier of the message is a `Nonce`. - Removed `Output::Message`. Now you don't need to specify it in the outputs. Because of that `SMO` opcode doesn't require a message output index anymore. - The proof API is updated with a new design: FuelLabs/fuel-core#1046. If you want to prove the block at height `X` you need at least a committed `X + 1` block. Because some of opcodes were updated the examples require a new `sway`. The corresponding PR: FuelLabs/sway#4525. It creates a cycle of dependencies with this PR. Closes #829 #933 --------- Co-authored-by: iqdecay <victor@berasconsulting.com> Co-authored-by: Brandon Kite <brandonkite92@gmail.com> Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com> Co-authored-by: Halil Beglerović <git@hal3e.io> Co-authored-by: hal3e <hal3e.git@gmail.com>
|
FuelLabs/fuels-rs#950 has been merged |
# Conflicts: # sway-core/src/semantic_analysis/ast_node/expression/intrinsic_function.rs
kayagokalp
previously approved these changes
May 26, 2023
|
The PR is ready for the final review. It uses SDK |
Taking care of it, opened #4595 |
kayagokalp
added a commit
that referenced
this pull request
May 29, 2023
…ay reference examples (#4597) ## Description closes #4595. unblocks #4525. Once #4596 is fixed we can remove std declarations in each manifest file with a single patch statement in the workspace level manifest file. That will also open the way to re-enable the disabled member (reentrancy) as the example depends on sway-lib and sway-lib depends on latest released std. So without the patch table it is not useable. follow-up: #4596.
|
Merged the fix here, it should clear CI stuff |
kayagokalp
approved these changes
May 29, 2023
JoshuaBatty
approved these changes
May 29, 2023
sdankel
approved these changes
May 30, 2023
sdankel
approved these changes
May 30, 2023
vaivaswatha
approved these changes
May 31, 2023
IGI-111
added a commit
that referenced
this pull request
May 31, 2023
## Description Waiting for: - #4525. @Dhaiwat10 was waiting for a release with the linked PR merged. @IGI-111 I had the PR ready, leaving it up to you when to merge & cut the release. Made this a major bump as we had a breaking change merged (#4574). ## Checklist - [ ] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [ ] I have requested a review from the relevant team or maintainers. Co-authored-by: IGI-111 <igi-111@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes breakings changes from the
fuel-core 0.18.1andfuels-rs 0.41.__smois reworked and doesn't require an output index because we removed theOutput::Messagevariant.Contract::deploy->Contract::load_from().deploy().ChainIdnow. It breaks the API in some places. In tests, I used the default chain id, but from theforcperspective we need to add the ability to specify it.fuels-signerswas renamed intofuels-accounts.fuel_tx::Inputand now each variant of the enum has a named type.fuel-cryptowith safe analog.fuel-tx/fuel-coreside now, there is a difference in whether the message contains data. If data is empty, it isMessageCointhat acts like aCoin(has the same rules during execution). If the data field is not empty, then it is a retryable message(orMessageData). Messages like this can't be used to pay a transaction fee, and if the execution fails, the message is not consumed(you can use it again in the next transactions). More about them you can read in Retryable Messages fuel-core#946. Also, the API changed for resources and not it isCoinsagain. Because of that, some tests now require messages with empty data to be able to spend them.MessageIdand corresponding fields. Now the identifier of the message is aNonce.Output::Message. Now you don't need to specify it in the outputs. Because of thatSMOopcode doesn't require a message output index anymore.u32in someu64) by introducing theBlockHeighttype.noncein theMessageis aBytes32now instead ofu64(affectedinput_message_nonceGTF).Intrinsic::Smo. Previouslyfuel-vmexpectedsmo(r1: receipt_and_message_ptr, r2: size_of_the_message, r3: output_index, r4: amount)but we updated that to besmo(r1: receipt_ptr, r2: message_ptr, r3: size_of_the_message, r4: amount)- according to the specification.input_message_msg_idGTF.SMOor another transfer. So in some tests first we need to transfer money to the contract first.fuels-rsnow generates a separate structure for encoder{Contract_name}Encoder.This PR is based on the FuelLabs/fuels-rs#950 and causes cycle dependencies. The
fuels-rsshould be released first and after we can apply it.