Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated abi tests #1152

Merged
merged 5 commits into from
Apr 6, 2022
Merged

Updated abi tests #1152

merged 5 commits into from
Apr 6, 2022

Conversation

eureka-cpu
Copy link
Contributor

Closes #1124

Found that the majority of contracts aren't being tested while sorting out #526 so I'm adding them here.

@eureka-cpu eureka-cpu added forc testing General testing labels Apr 5, 2022
@eureka-cpu eureka-cpu self-assigned this Apr 5, 2022
@eureka-cpu eureka-cpu added the P: critical Should be looked at before anything else label Apr 5, 2022
@eureka-cpu eureka-cpu marked this pull request as ready for review April 5, 2022 18:56
sezna
sezna approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@sezna sezna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eureka-cpu eureka-cpu merged commit 303bb29 into master Apr 6, 2022
@eureka-cpu eureka-cpu deleted the eureka-cpu/add-abi-tests branch April 6, 2022 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sezna sezna sezna approved these changes

@mohammadfawaz mohammadfawaz Awaiting requested review from mohammadfawaz

@adlerjohn adlerjohn Awaiting requested review from adlerjohn

Assignees

@eureka-cpu eureka-cpu

Labels
forc P: critical Should be looked at before anything else testing General testing
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some test contracts aren't in the ABI check
2 participants
@eureka-cpu @sezna