Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move forc's block explorer support into a dedicated forc-explore plugin crate #1180

Merged
merged 6 commits into from
Apr 8, 2022
Merged

Move forc's block explorer support into a dedicated forc-explore plugin crate #1180

merged 6 commits into from
Apr 8, 2022

Conversation

mitchmindtree
Copy link
Contributor

@mitchmindtree mitchmindtree commented Apr 7, 2022 •
edited
Loading

NOTE: This PR is Based on #1178.

I've taken the liberty to clean-up/refactor the code a little during the move too.

Closes #946.

@mitchmindtree mitchmindtree self-assigned this Apr 7, 2022
@mitchmindtree mitchmindtree mentioned this pull request Apr 7, 2022
Closed
@mitchmindtree mitchmindtree force-pushed the mitchmindtree/forc-explore-plugin branch 2 times, most recently from 952e4a8 to 8060ec3 Compare April 8, 2022 00:26
@mitchmindtree mitchmindtree marked this pull request as ready for review April 8, 2022 00:50
JoshuaBatty
JoshuaBatty previously approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, looks good.

adlerjohn
adlerjohn reviewed Apr 8, 2022
View reviewed changes
forc-explore/Cargo.toml Outdated Show resolved Hide resolved
adlerjohn
adlerjohn reviewed Apr 8, 2022
View reviewed changes
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're here, could you use major.minor for non-Fuel deps in this new crate instead of major.minor.patch?

@mitchmindtree mitchmindtree force-pushed the mitchmindtree/forc-explore-plugin branch from a0066a7 to 35f942c Compare April 8, 2022 02:59
sezna
sezna approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@sezna sezna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once again, mostly just moved code right? nice, loving the plugin system. this is awesome

@mitchmindtree mitchmindtree merged commit 4b83356 into master Apr 8, 2022
@mitchmindtree mitchmindtree deleted the mitchmindtree/forc-explore-plugin branch April 8, 2022 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@sezna sezna sezna approved these changes

@digorithm digorithm Awaiting requested review from digorithm

@AlicanC AlicanC Awaiting requested review from AlicanC

@luizstacio luizstacio Awaiting requested review from luizstacio

@adlerjohn adlerjohn Awaiting requested review from adlerjohn

Assignees

@mitchmindtree mitchmindtree

Labels
code quality enhancement New feature or request forc
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move forc explore command into a dedicated forc-explore executable crate
4 participants
@mitchmindtree @JoshuaBatty @adlerjohn @sezna