Update CI to install forc and build sway examples #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchmindtree
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
LGTM!
I think this makes much more sense than committing out/debug/<proj>-abi.json files, as at least this way we can always make sure the ABI files for the examples are up-to-date.
It's annoying there isn't a simple way to re-use a sequence of steps without writing a whole github action. Maybe one day github will give us "function"s, or let jobs "branch" out to other jobs or something. Meanwhile this is probably fine.
I would be more worried about the cargo install of forc taking up more CI time, but the rust-cache should make this pretty negligible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is currently failing for PR #1321. This is because the
outdirectory isn't being built for the sway examples, leading to CI errors for:cargo-build-workspacecargo-clippycargo-test-lib-stdcargo-test-workspacecargo-unused-deps-checkThis PR now installs
forcand builds all sway examples during each of these stages now.