Remove explicit std in getting started example
#1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -85,7 +85,6 @@ license = "Apache-2.0" | |||
| name = "wallet_contract" | |||
|
|
|||
| [dependencies] | |||
There was a problem hiding this comment.
We should probably remove [dependencies] to match the behaviour of forc init.
There was a problem hiding this comment.
forc init has a [dependencies], as does cargo init.
There was a problem hiding this comment.
What's actually bad is that we discussed this in my PR #1226 10 days ago.
SilentCicero
previously approved these changes
Apr 21, 2022
adlerjohn
force-pushed
the
adlerjohn/remove-explicit-std
branch
from
56736ea
to
01b714d
Compare
mohammadfawaz
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.