Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump fuels* to 0.12 #1520

Merged
merged 3 commits into from
May 11, 2022
Merged

Bump fuels* to 0.12 #1520

merged 3 commits into from
May 11, 2022

Conversation

Voxelot
Copy link
Member

@Voxelot Voxelot commented May 11, 2022 •
edited
Loading

The default harness provided by forc was using out of date versions, this should hopefully address any out of date deps with fuels.

@Voxelot Voxelot self-assigned this May 11, 2022
adlerjohn
adlerjohn reviewed May 11, 2022
View reviewed changes
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failing

@mohammadfawaz
Copy link
Contributor

@nfurfaro updated the lib-std tests here #1523 so that should get rid of the lib-std test failures.

As for the other CI failure, the default test harness of forc init should probably be updated.

@Voxelot
Copy link
Member Author

Voxelot commented May 11, 2022

@mohammadfawaz Seems like we can close this one? Looks like @nfurfaro's PR already made all the needed changes.

@mohammadfawaz
Copy link
Contributor

mohammadfawaz commented May 11, 2022 •
edited
Loading

@mohammadfawaz Seems like we can close this one? Looks like @nfurfaro's PR already made all the needed changes.

Nick only changed files under test/src/sdk-harness/. You have other changes here that are probably needed as well.

@Voxelot
Copy link
Member Author

Voxelot commented May 11, 2022

@mohammadfawaz ci is passing now, it's ready to merge

mohammadfawaz
mohammadfawaz approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@mohammadfawaz mohammadfawaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Voxelot Voxelot merged commit f6b0366 into master May 11, 2022
@Voxelot Voxelot deleted the voxelot/forc-harness-update branch May 11, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerjohn adlerjohn adlerjohn left review comments

@mohammadfawaz mohammadfawaz mohammadfawaz approved these changes

@digorithm digorithm Awaiting requested review from digorithm

@mitchmindtree mitchmindtree Awaiting requested review from mitchmindtree

Assignees

@Voxelot Voxelot

Labels
dependencies
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Voxelot @mohammadfawaz @adlerjohn