Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't forward too much gas in the reentrancy test #2323

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Don't forward too much gas in the reentrancy test #2323

merged 1 commit into from
Jul 14, 2022

Conversation

mohammadfawaz
Copy link
Contributor

@mohammadfawaz mohammadfawaz commented Jul 14, 2022 •
edited
Loading

Fixes the CI problem.

@mohammadfawaz mohammadfawaz self-assigned this Jul 14, 2022
@mohammadfawaz mohammadfawaz added the testing General testing label Jul 14, 2022
@mohammadfawaz mohammadfawaz marked this pull request as ready for review July 14, 2022 14:08
@mohammadfawaz mohammadfawaz requested review from adlerjohn, a team and nfurfaro July 14, 2022 14:09
@mohammadfawaz mohammadfawaz enabled auto-merge (squash) July 14, 2022 14:11
nfurfaro
nfurfaro approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@nfurfaro nfurfaro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK.
Though if there is a max_gas_per_tx, why is it not ok to use it?

@mohammadfawaz mohammadfawaz merged commit 21aee93 into master Jul 14, 2022
@mohammadfawaz mohammadfawaz deleted the mohammadfawaz/dont_forward_too_much_gas branch July 14, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerjohn adlerjohn adlerjohn approved these changes

@nfurfaro nfurfaro nfurfaro approved these changes

Assignees

@mohammadfawaz mohammadfawaz

Labels
testing General testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohammadfawaz @adlerjohn @nfurfaro