Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move build logic to forc-pkg from forc #2478

Merged
merged 4 commits into from
Aug 9, 2022
Merged

refactor: move build logic to forc-pkg from forc #2478

merged 4 commits into from
Aug 9, 2022

Conversation

kayagokalp
Copy link
Member

@kayagokalp kayagokalp commented Aug 8, 2022 •
edited
Loading

closes #2479

@kayagokalp kayagokalp requested a review from a team August 8, 2022 13:45
@kayagokalp kayagokalp self-assigned this Aug 8, 2022
@kayagokalp kayagokalp mentioned this pull request Aug 8, 2022
Merged
@kayagokalp
Copy link
Member Author

Adding the "critical" tag as this is blocking a issue tagged with "critical"

@kayagokalp kayagokalp added the P: critical Should be looked at before anything else label Aug 8, 2022
@kayagokalp kayagokalp marked this pull request as ready for review August 8, 2022 14:04
@JoshuaBatty
Copy link
Member

Hi @kayagokalp i'm happy to approve this, just need to bump the versions to 0.19.2 first.

@kayagokalp kayagokalp enabled auto-merge (squash) August 9, 2022 08:50
@JoshuaBatty JoshuaBatty requested a review from a team August 9, 2022 12:04
eureka-cpu
eureka-cpu approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@eureka-cpu eureka-cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kayagokalp kayagokalp merged commit 2bccbd5 into master Aug 9, 2022
@kayagokalp kayagokalp deleted the kayagokalp/refactor_build branch August 9, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@eureka-cpu eureka-cpu eureka-cpu approved these changes

Assignees

@kayagokalp kayagokalp

Labels
code quality forc P: critical Should be looked at before anything else
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move build logic to forc-pkg
3 participants
@kayagokalp @JoshuaBatty @eureka-cpu