b256 functions for stdlib.
#256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when replacing labels with offsets it assumed that all virtual ops are 1 word in size after conversion to VM ops. This isn't necessarily true for LWDataId which can be realised as an LW followed by an ADD when loading a data section offset, for datatypes larger than a single word.
- `eq()` for comparisons. - `hash_value()` and `hash_pair()` for SHA256 or Keccak256 hashing.
otrho
force-pushed
the
otrho/218_b256_stdlib
branch
from
20612a5
to
94e24e6
Compare
|
Hrmm, was just thinking maybe the hash functions should be split out into a |
I have another PR where I do that for the |
sezna
approved these changes
Sep 22, 2021
|
Going to pull this in now (sorry for stealing the "merge" button press from you) so I can organize the stdlib. |
adlerjohn
added
compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a couple of changes. Addresses #218 but we will want to add more functionality in the future.
Firstly this fixes a bug in ASM gen which didn't account for the possibility of
LWDataIdusing two VM ops when calculating offsets for labels.Secondly it adds some initial support for
b256in the stdlib:eq()but notlt()norgt(). The latter will require some extra support either from the VM or from the Sway virtual ops (more likely).hash_value()takes a singleb256value and hashes it to anotherb256value using either SHA256 or Keccak256.hash_pair()takes twob256values and hashes them contiguously to ab256value similarly.