Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions for manipulating b256 values to the stdlib. #218

Closed
otrho opened this issue Sep 10, 2021 · 4 comments
Closed

Add functions for manipulating b256 values to the stdlib. #218

otrho opened this issue Sep 10, 2021 · 4 comments
Labels
big this task is hard and will take a while lib: std Standard library

Comments

@otrho
Copy link
Contributor

otrho commented Sep 10, 2021

b256 values are typically addresses or other hashes which require support from the standard library.

@otrho otrho added the lib: std Standard library label Sep 10, 2021
@otrho
Copy link
Contributor Author

otrho commented Sep 10, 2021

Is #33 still a thing? Do we want to handle address types in the stdlib too?

@otrho
Copy link
Contributor Author

otrho commented Sep 13, 2021

As per a discussion on Slack, we should implement (at least) the following traits for b256:

  • Ord (includes eq()).
  • Hash.

Hash isn't a trait yet though, but it should be a simple wrapper around the K256 and S256 instructions for single types.

Ideally we want to be able to hash a collection of b256s, in particular a tuple pair (see #156) or array.

@otrho otrho self-assigned this Sep 13, 2021
@sezna sezna added the big this task is hard and will take a while label Sep 22, 2021
@otrho otrho removed their assignment Sep 23, 2021
@nfurfaro
Copy link
Contributor

@otrho Can this be closed?

@otrho
Copy link
Contributor Author

otrho commented May 16, 2022

I guess? We can/do have other specific issues for any further work.

@otrho otrho closed this as completed May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
big this task is hard and will take a while lib: std Standard library
Projects
Archived in project
Development

No branches or pull requests

3 participants