Fold CMP and CBR instructions #2615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otrho
reviewed
Aug 24, 2022
Comment on lines
+483
to
+484
| // TODO: Experiment with putting combine-constants and simplify-cfg | ||
| // in a loop, but per function. |
There was a problem hiding this comment.
Or really, we need to create a pass manager in sway-ir. It could initially just call all the passes consecutively and repeatedly until nothing changes (if that isn't too expensive) but it doesn't belong here in lib.rs any more.
|
Apart from the nits, all good! I'm glad it's already making a difference. |
otrho
approved these changes
Aug 24, 2022
|
This change also replaces expressions such as the one below with and it looks like, when there are no further removal of dead blocks in that program, the code size actually increases a little bit. There are no other changes apart from these in the IR that I inspected, for the tests which have a slight code size increase. Full results:
|
|
So the files that are larger are just because |
I didn't check them all, but the ones I manually inspected, yes. And yes, we should do this optimization at some point. |
15 tasks
mohammadfawaz
added
compiler: ir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables more opportunities for
simplify-cfg, which in-turn enables morecmpandcbrfolding (as some intermediate PHIs get removed bysimplify-cfg).I haven't yet done a full benchmarking, but for the
basic_storagetest, which uses a lot of code fromstd::storage, which in-turn has code of the formif !is_reference_type...(which is statically evaluatable), I saw the bytecode size reduce from 20k to about 11.7k.edit: numbers on the full testsuite is added as comment down below.