Fuel Core v0.17.0 Upgrade #3961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Cargo.lock # forc-plugins/forc-client/Cargo.toml # forc-plugins/forc-client/src/op/run.rs # forc-plugins/forc-client/src/ops/deploy/cmd.rs # forc-plugins/forc-client/src/ops/run/cmd.rs # forc-plugins/forc-doc/Cargo.toml # forc-plugins/forc-tx/Cargo.toml # forc-test/Cargo.toml # sway-core/Cargo.toml # sway-lib-std/src/inputs.sw # test/src/sdk-harness/Cargo.toml
Added `ci_check.sh` script that allows to run all check by one command locally.
# Conflicts: # Cargo.lock
Merge with master
mohammadfawaz
previously approved these changes
Feb 1, 2023
tritao
previously approved these changes
Feb 1, 2023
|
This PR shouldn't be merged until fuels-rs is released, putting into draft for now |
Voxelot
added a commit
to FuelLabs/fuels-rs
that referenced
this pull request
Feb 2, 2023
###### Description of changes
Update `fuels-rs` to the latest `fuel-core 0.16.1` and latest `sway
0.34.0`.
Due to changes in `fuel-asm` for GTF, this is causing yet another
circular upgrade issue.
- Used `{ workspace = true }` syntax to use one version across the
project and simplify integration with new changes in the future.
- Added `ci_checks.sh` script to compile all tests to simplify
integration of changes like this in the future.
- Update contracts to be compatible with `sway 0.34.0`.
- Updated tests to be compatible with `fuel-core 0.16.1`.
related PR: FuelLabs/sway#3961
---------
Co-authored-by: green <xgreenx9999@gmail.com>
8 tasks
…, `fuel-core` -> `0.17`. (#4004) NOTE: This PR is against @Voxelot's PR branch here: #3961. This updates all crates for the recent upstream `fuel-asm` refactor. To learn more about the refactor, see the original PR at the fuel-vm repo: FuelLabs/fuel-vm#283. The fuel-core update PR can be found here: FuelLabs/fuel-core#973. ## TODO - [x] Update `fuels` for `fuel-asm` change. `fuels-core` errors in the `offsets` module. Will address this now and then update this PR. ## Follow-up - [Rename `AllocatedOpcode` to `AllocatedInstruction` to follow fuel-spec/fuel-asm terminology.](#4006) ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers. --------- Co-authored-by: bingcicle <bingcicle@proton.me> Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
# Conflicts: # .github/workflows/ci.yml # forc-test/src/lib.rs
mohammadfawaz
approved these changes
Feb 8, 2023
mitchmindtree
approved these changes
Feb 8, 2023
MujkicA
pushed a commit
to FuelLabs/fuels-rs
that referenced
this pull request
Feb 10, 2023
Update `fuels-rs` to the latest `fuel-core 0.16.1` and latest `sway
0.34.0`.
Due to changes in `fuel-asm` for GTF, this is causing yet another
circular upgrade issue.
- Used `{ workspace = true }` syntax to use one version across the
project and simplify integration with new changes in the future.
- Added `ci_checks.sh` script to compile all tests to simplify
integration of changes like this in the future.
- Update contracts to be compatible with `sway 0.34.0`.
- Updated tests to be compatible with `fuel-core 0.16.1`.
related PR: FuelLabs/sway#3961
---------
Co-authored-by: green <xgreenx9999@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: FuelLabs/fuels-rs#813
{ workspace = true }syntax to use one version across the project and simplify integration with new changes in the future.ci_checks.shscript to compile all tests to simplify integration of changes like this in the future.fuels-rsandfuel-core 0.16.1.Due to changes in
fuel-asmfor GTF, this is causing yet another circular upgrade issue.