Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename AllocatedOpcode to AllocatedInstruction to follow fuel-spec/fuel-asm terminology #4006

Open
mitchmindtree opened this issue Feb 7, 2023 · 3 comments
Open

Rename AllocatedOpcode to AllocatedInstruction to follow fuel-spec/fuel-asm terminology #4006

mitchmindtree opened this issue Feb 7, 2023 · 3 comments
Labels
code quality compiler: codegen Everything to do with IR->ASM, register allocation, etc. compiler General compiler. Should eventually become more specific as the issue is triaged good first issue Good for newcomers

Comments

@mitchmindtree
Copy link
Contributor

Follow-up to the fuel-asm refactor changes here: #4004. We should check other usage of the term Opcode too.
@mitchmindtree mitchmindtree added good first issue Good for newcomers compiler General compiler. Should eventually become more specific as the issue is triaged code quality compiler: codegen Everything to do with IR->ASM, register allocation, etc. labels Feb 7, 2023
@mitchmindtree mitchmindtree mentioned this issue Feb 7, 2023
Merged
8 tasks
@otrho
Copy link
Contributor

otrho commented Feb 7, 2023

Mentioning #2906

@gr00vytvniks
Copy link
Contributor

I can open a PR for this today if nobody is assigned already!

@mitchmindtree
Copy link
Contributor Author

We likely want to land #4004 first, which should hopefully happen today.

Voxelot added a commit that referenced this issue Feb 8, 2023
@mitchmindtree @eightfilms @Voxelot
Update all crates for recent fuel-asm refactor. fuel-vm -> 0.26…
8f4d6ca 
…, `fuel-core` -> `0.17`. (#4004)

NOTE: This PR is against @Voxelot's PR branch here:
#3961.

This updates all crates for the recent upstream `fuel-asm` refactor.

To learn more about the refactor, see the original PR at the fuel-vm
repo: FuelLabs/fuel-vm#283.

The fuel-core update PR can be found here:
FuelLabs/fuel-core#973.

## TODO

- [x] Update `fuels` for `fuel-asm` change. `fuels-core` errors in the
`offsets` module. Will address this now and then update this PR.

## Follow-up

- [Rename `AllocatedOpcode` to `AllocatedInstruction` to follow
fuel-spec/fuel-asm
terminology.](#4006)

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.

---------

Co-authored-by: bingcicle <bingcicle@proton.me>
Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality compiler: codegen Everything to do with IR->ASM, register allocation, etc. compiler General compiler. Should eventually become more specific as the issue is triaged good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@otrho @mitchmindtree @gr00vytvniks