-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch the Sway sdk-harness
tests to use Forc
workspaces instead of the bash script build.sh
#4476
Merged
mohammadfawaz
merged 2 commits into
master
from
mohammadfawaz/workspaces_in_sdk_harness_tests
Apr 20, 2023
Merged
Switch the Sway sdk-harness
tests to use Forc
workspaces instead of the bash script build.sh
#4476
mohammadfawaz
merged 2 commits into
master
from
mohammadfawaz/workspaces_in_sdk_harness_tests
Apr 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ash script `build.sh`
mohammadfawaz
commented
Apr 20, 2023
sdk-harness
tests to use workspace instead of the bash script build.sh
sdk-harness
tests to use Forc
workspaces instead of the bash script build.sh
nfurfaro
previously approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good upgrade, thanks!
eightfilms
reviewed
Apr 20, 2023
kayagokalp
previously approved these changes
Apr 20, 2023
eightfilms
reviewed
Apr 20, 2023
Co-authored-by: bing <bingcicle@proton.me>
75fa8c6
to
fafde2d
Compare
eightfilms
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🛳️
kayagokalp
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that we have
Forc
workspaces, we can just have a workspace for all thesdk-harness
tests instead of having to compile the tests manually usingbuild.sh
.Checklist
Breaking*
orNew Feature
labels where relevant.