Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch the Sway sdk-harness tests to use Forc workspaces instead of the bash script build.sh #4476

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Switch the Sway sdk-harness tests to use Forc workspaces instead of the bash script build.sh #4476

merged 2 commits into from
Apr 20, 2023

Conversation

mohammadfawaz
Copy link
Contributor

@mohammadfawaz mohammadfawaz commented Apr 20, 2023 •
edited
Loading

Description

Now that we have Forc workspaces, we can just have a workspace for all the sdk-harness tests instead of having to compile the tests manually using build.sh.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@mohammadfawaz mohammadfawaz self-assigned this Apr 20, 2023
@mohammadfawaz mohammadfawaz added the testing General testing label Apr 20, 2023
@mohammadfawaz mohammadfawaz marked this pull request as ready for review April 20, 2023 15:20
@mohammadfawaz mohammadfawaz requested review from nfurfaro and a team April 20, 2023 15:21
@mohammadfawaz mohammadfawaz changed the title Switch the Sway sdk-harness tests to use workspace instead of the bash script build.sh Switch the Sway sdk-harness tests to use Forc workspaces instead of the bash script build.sh Apr 20, 2023
nfurfaro
nfurfaro previously approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@nfurfaro nfurfaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good upgrade, thanks!

kayagokalp
kayagokalp previously approved these changes Apr 20, 2023
View reviewed changes
@mohammadfawaz @eightfilms
Update test/src/sdk-harness/README.md
fafde2d 
Co-authored-by: bing <bingcicle@proton.me>
@mohammadfawaz mohammadfawaz force-pushed the mohammadfawaz/workspaces_in_sdk_harness_tests branch from 75fa8c6 to fafde2d Compare April 20, 2023 17:40
eightfilms
eightfilms approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@eightfilms eightfilms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 🚢 🛳️

@mohammadfawaz mohammadfawaz enabled auto-merge (squash) April 20, 2023 17:47
@mohammadfawaz mohammadfawaz merged commit 98f886b into master Apr 20, 2023
@mohammadfawaz mohammadfawaz deleted the mohammadfawaz/workspaces_in_sdk_harness_tests branch April 20, 2023 18:00
@iqdecay iqdecay mentioned this pull request May 3, 2023
Merged
iqdecay added a commit that referenced this pull request May 3, 2023
@iqdecay
chore: remove leftover build.sh (#4529)
befca87 
This file was removed in #4476  but reintroduced in #4464.
@kayagokalp kayagokalp mentioned this pull request May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayagokalp kayagokalp kayagokalp approved these changes

@eightfilms eightfilms eightfilms approved these changes

@nfurfaro nfurfaro Awaiting requested review from nfurfaro

Assignees

@mohammadfawaz mohammadfawaz

Labels
testing General testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mohammadfawaz @nfurfaro @kayagokalp @eightfilms