Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename fn_args_layout to fn_params_layout in rustfmt.toml #4530

Merged
merged 2 commits into from
May 4, 2023

Conversation

kayagokalp
Copy link
Member

@kayagokalp kayagokalp commented May 3, 2023

Description

Since rust-lang/rustfmt#4149 is released with latest rust toolchain 1.69, we are seeing some warnings from rustfmt. This PR addresses the depreciation note in our rustfmt.toml.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@kayagokalp kayagokalp self-assigned this May 3, 2023
@kayagokalp kayagokalp changed the title chore: rust-fmt-field rename chore: rename fn_args_layout to fn_params_layout in rust-fmt.toml May 3, 2023
@kayagokalp kayagokalp changed the title chore: rename fn_args_layout to fn_params_layout in rust-fmt.toml chore: rename fn_args_layout to fn_params_layout in rust-fmt.toml May 3, 2023
@kayagokalp kayagokalp changed the title chore: rename fn_args_layout to fn_params_layout in rust-fmt.toml chore: rename fn_args_layout to fn_params_layout in rustfmt.toml May 3, 2023
@kayagokalp kayagokalp requested review from a team May 3, 2023 17:46
@kayagokalp kayagokalp marked this pull request as ready for review May 3, 2023 17:46
@kayagokalp kayagokalp enabled auto-merge (squash) May 3, 2023 17:46
@kayagokalp kayagokalp disabled auto-merge May 3, 2023 20:26
@kayagokalp kayagokalp enabled auto-merge (squash) May 3, 2023 20:27
@kayagokalp kayagokalp merged commit 1a881ee into master May 4, 2023
@kayagokalp kayagokalp deleted the kayagokalp/rust-fmt-rename-field branch May 4, 2023 08:23
@eightfilms
Copy link
Contributor

So I reran the test but there seems to be a flaky test (job):

 thread 'tx_fields::outputs::revert::contract::fails_to_get_amount_for_output_contract' panicked at 'called `Result::unwrap()` on an `Err` value: RevertTransactionError { reason: "Revert(0)", revert_id: 0, receipts: [Call { id: 0000000000000000000000000000000000000000000000000000000000000000, to: ec1e6cc490636d1f75fcc4d160ab018b541dae89fb660559f5ca460675516f65, amount: 0, asset_id: 0000000000000000000000000000000000000000000000000000000000000000, gas: 1000000, param1: 2522642525, param2: 0, pc: 11632, is: 11632 }, Revert { id: ec1e6cc490636d1f75fcc4d160ab018b541dae89fb660559f5ca460675516f65, ra: 0, pc: 19784, is: 11632 }, ScriptResult { result: Revert, gas_used: 1023 }] }', test_projects/tx_fields/mod.rs:783:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants