Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename fn_args_layout config option #4149

Closed
calebcartwright opened this issue May 1, 2020 · 1 comment · Fixed by #4163 or #5387
Closed

Rename fn_args_layout config option #4149

calebcartwright opened this issue May 1, 2020 · 1 comment · Fixed by #4163 or #5387
Labels
good first issue Issues up for grabs, also good candidates for new rustfmt contributors help wanted

Comments

@calebcartwright
Copy link
Member

We previously (#3803) refactored the arg name to param internally within rustfmt where appropriate to reflect the upstream changes (rust-lang/rust#62426), but did not change the public/external-facing fn_args_layout config option because that would have been a breaking change.

However, this config option is indeed used as part of the formatting of the parameters in a fn signature, not in the formatting of args in a fn call. As such this should also be renamed as part of the major version release (fn_params_layout seems like a reasonable name)

@topecongiro I've added this to the 2.0 milestone per our previous discussion in #3803 (comment), but of course feel free to change that if you think we should defer it.

Below are the steps involved for anyone interested in working on this:

@calebcartwright calebcartwright added good first issue Issues up for grabs, also good candidates for new rustfmt contributors help wanted labels May 1, 2020
@calebcartwright calebcartwright added this to the 2.0.0 milestone May 1, 2020
ayazhafiz added a commit to ayazhafiz/rustfmt that referenced this issue May 9, 2020
See rust-lang#4149 for more details. This change is targeted for rustfmt 2.0.

Closes rust-lang#4149
@karyon
Copy link
Contributor

karyon commented Oct 29, 2021

Reopening for 1.x according to @calebcartwright's comment: "there should be a path to a "soft" deprecation where we just print a warning when encountering the option for user awareness, but automatically map the value over to the new option. [...] anyone that wants to work on that could use the commits from #4163 as a building block, and then just add the warning/mapping behavior on top"

@karyon karyon reopened this Oct 29, 2021
@calebcartwright calebcartwright removed this from the 2.0.0 milestone Jun 16, 2022
kayagokalp added a commit to FuelLabs/sway that referenced this issue May 4, 2023
#4530)

## Description
Since rust-lang/rustfmt#4149 is released with latest rust toolchain 1.69, we are seeing some warnings from rustfmt. This PR addresses the depreciation note in our `rustfmt.toml`.
kayagokalp added a commit to FuelLabs/fuels-rs that referenced this issue Jun 16, 2023
#994)

Since rust-lang/rustfmt#4149 is released with
latest rust toolchain 1.69, we are seeing some warnings from rustfmt.
This PR addresses the depreciation note coming from rustfmt.toml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues up for grabs, also good candidates for new rustfmt contributors help wanted
Projects
None yet
2 participants