Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a way to specify expected revert code to forc-test #4554

Merged
merged 7 commits into from
May 18, 2023
Merged

feat: add a way to specify expected revert code to forc-test #4554

merged 7 commits into from
May 18, 2023

Conversation

kayagokalp
Copy link
Member

@kayagokalp kayagokalp commented May 9, 2023 •
edited
Loading

Description

closes #3544.

Enables users to provide a specified revert code with their should_revert tests.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@kayagokalp kayagokalp added enhancement New feature or request forc-test Everything related to the `forc-test` lib and `forc test` command. labels May 9, 2023
@kayagokalp kayagokalp self-assigned this May 9, 2023
@kayagokalp kayagokalp marked this pull request as ready for review May 9, 2023 23:30
@kayagokalp kayagokalp requested a review from a team May 9, 2023 23:30
@kayagokalp kayagokalp enabled auto-merge (squash) May 9, 2023 23:31
sdankel
sdankel approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@sdankel sdankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kayagokalp kayagokalp requested a review from a team May 15, 2023 20:44
mitchmindtree
mitchmindtree approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@mitchmindtree mitchmindtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@kayagokalp kayagokalp merged commit 81731c5 into master May 18, 2023
22 checks passed
@kayagokalp kayagokalp deleted the kayagokalp/3544 branch May 18, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchmindtree mitchmindtree mitchmindtree approved these changes

@sdankel sdankel sdankel approved these changes

Assignees

@kayagokalp kayagokalp

Labels
enhancement New feature or request forc-test Everything related to the `forc-test` lib and `forc test` command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a way to specify expected revert value to forc-test
3 participants
@kayagokalp @mitchmindtree @sdankel