Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to specify expected revert value to forc-test #3544

Closed
kayagokalp opened this issue Dec 8, 2022 · 1 comment · Fixed by #4554
Closed

Add a way to specify expected revert value to forc-test #3544

kayagokalp opened this issue Dec 8, 2022 · 1 comment · Fixed by #4554
Assignees
@kayagokalp
Labels
enhancement New feature or request forc-test Everything related to the `forc-test` lib and `forc test` command. good first issue Good for newcomers

Comments

@kayagokalp
Copy link
Member

kayagokalp commented Dec 8, 2022 •
edited
Loading

Related to #3490 (review).

While implementing this we can also clean the two suggestions from:

  1. feat: #[test(should_revert)] attribute to indicate a unit test should revert #3490 (comment)
  2. feat: #[test(should_revert)] attribute to indicate a unit test should revert #3490 (comment)
@kayagokalp kayagokalp added enhancement New feature or request good first issue Good for newcomers forc-test Everything related to the `forc-test` lib and `forc test` command. labels Dec 8, 2022
@kayagokalp
Copy link
Member Author

Adding "blocked" as this requires modifying the parser too. I will open-up a separate issue for that.

@kayagokalp kayagokalp mentioned this issue Dec 12, 2022
Closed
@nfurfaro nfurfaro mentioned this issue Jan 31, 2023
Closed
@otrho otrho mentioned this issue Feb 24, 2023
Merged
@kayagokalp kayagokalp self-assigned this Apr 20, 2023
@kayagokalp kayagokalp mentioned this issue May 9, 2023
Merged
7 tasks
kayagokalp added a commit that referenced this issue May 18, 2023
@kayagokalp
feat: add a way to specify expected revert code to forc-test (#4554)
81731c5 
## Description
closes #3544.

Enables users to provide a specified revert code with their
`should_revert` tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kayagokalp kayagokalp

Labels
enhancement New feature or request forc-test Everything related to the `forc-test` lib and `forc test` command. good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add a way to specify expected revert code to forc-test FuelLabs/sway
1 participant
@kayagokalp