Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pub token being removed by swayfmt #4612

Merged
merged 1 commit into from
May 31, 2023
Merged

Fix pub token being removed by swayfmt #4612

merged 1 commit into from
May 31, 2023

Conversation

IGI-111
Copy link
Contributor

@IGI-111 IGI-111 commented May 31, 2023

Description

Fix a bug where the pub token in any pub mod expression would get elided by swayfmt.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@IGI-111
Fix pub token being removed by swayfmt
9ce39e0 
Fix a bug where the `pub` token in any `pub mod` expression would get
elided by swayfmt.
@IGI-111 IGI-111 added bug Something isn't working formatter labels May 31, 2023
@IGI-111 IGI-111 requested a review from a team May 31, 2023 14:27
@IGI-111 IGI-111 self-assigned this May 31, 2023
@IGI-111 IGI-111 requested a review from a team May 31, 2023 14:28
@K1-R1 K1-R1 linked an issue May 31, 2023 that may be closed by this pull request
forc-fmt 0.40.0 removes the pub in any pub mod now needed with the new module privacy rules #4611
Closed
@esdrubal esdrubal merged commit 26a2e28 into master May 31, 2023
@esdrubal esdrubal deleted the IGI-111/fix-pub-mod-fmt-bug branch May 31, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritao tritao tritao approved these changes

@esdrubal esdrubal esdrubal approved these changes

Assignees

@IGI-111 IGI-111

Labels
bug Something isn't working formatter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forc-fmt 0.40.0 removes the pub in any pub mod now needed with the new module privacy rules
3 participants
@IGI-111 @tritao @esdrubal