Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add encoding capability to forc-client for variable encoding #4680

Merged
merged 7 commits into from
Jul 3, 2023
Merged

feat: add encoding capability to forc-client for variable encoding #4680

merged 7 commits into from
Jul 3, 2023

Conversation

kayagokalp
Copy link
Member

@kayagokalp kayagokalp commented Jun 17, 2023 •
edited
Loading

Description

closes #4679.

This PR lays down the foundation for variable encoding in forc-client. Unblocks things like:

  1. forc run - allow for specifying main arguments for scripts #3439
  2. forc-client - support working with predicates #3440
  3. Add a forc call command for calling contract methods #3446

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@kayagokalp kayagokalp added enhancement New feature or request forc-client Everything related to the `forc-client` crate. labels Jun 17, 2023
@kayagokalp kayagokalp self-assigned this Jun 17, 2023
@kayagokalp kayagokalp marked this pull request as ready for review June 17, 2023 21:55
@kayagokalp kayagokalp requested a review from a team June 17, 2023 21:56
@kayagokalp kayagokalp enabled auto-merge (squash) June 17, 2023 21:56
JoshuaBatty
JoshuaBatty previously approved these changes Jun 18, 2023
View reviewed changes
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoshuaBatty JoshuaBatty requested a review from a team June 18, 2023 22:55
sdankel
sdankel previously approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@sdankel sdankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@kayagokalp kayagokalp dismissed stale reviews from sdankel and JoshuaBatty via 3639c3e June 26, 2023 21:20
JoshuaBatty
JoshuaBatty previously approved these changes Jun 26, 2023
View reviewed changes
@JoshuaBatty JoshuaBatty requested a review from a team June 26, 2023 21:51
sdankel
sdankel previously approved these changes Jun 29, 2023
View reviewed changes
@kayagokalp
Copy link
Member Author

Conflicts again :(

@kayagokalp kayagokalp dismissed stale reviews from sdankel and JoshuaBatty via f3a3d12 June 30, 2023 11:35
@kayagokalp kayagokalp requested review from sdankel and a team June 30, 2023 12:01
@JoshuaBatty JoshuaBatty requested a review from a team July 3, 2023 11:45
@kayagokalp kayagokalp merged commit 2e7c20e into master Jul 3, 2023
24 checks passed
@kayagokalp kayagokalp deleted the kayagokalp/4679 branch July 3, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritao tritao tritao approved these changes

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@sdankel sdankel Awaiting requested review from sdankel

Assignees

@kayagokalp kayagokalp

Labels
enhancement New feature or request forc-client Everything related to the `forc-client` crate.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement encoding logic for forc-client, so that use specified variables can be encoded while generating txs
4 participants
@kayagokalp @tritao @JoshuaBatty @sdankel