Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: report the name of failing dependencies that cannot be sourced #4715

Merged
merged 3 commits into from
Jun 30, 2023
Merged

feat: report the name of failing dependencies that cannot be sourced #4715

merged 3 commits into from
Jun 30, 2023

Conversation

kayagokalp
Copy link
Member

@kayagokalp kayagokalp commented Jun 28, 2023 •
edited
Loading

Description

closes #4685.

Improves error message for packages failing to be sourced by reporting failing package name. Especially useful debugging forc-pkg bugs.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@kayagokalp kayagokalp added enhancement New feature or request forc-pkg Everything related to the `forc-pkg` crate. labels Jun 28, 2023
@kayagokalp kayagokalp self-assigned this Jun 28, 2023
@kayagokalp kayagokalp marked this pull request as ready for review June 29, 2023 15:42
@kayagokalp kayagokalp requested a review from a team June 29, 2023 15:42
@kayagokalp kayagokalp merged commit 33fda5e into master Jun 30, 2023
28 checks passed
@kayagokalp kayagokalp deleted the kayagokalp/4685 branch June 30, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@sdankel sdankel sdankel approved these changes

Assignees

@kayagokalp kayagokalp

Labels
enhancement New feature or request forc-pkg Everything related to the `forc-pkg` crate.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Report the name of failing dependency for dependencies failing to be sourced
3 participants
@kayagokalp @JoshuaBatty @sdankel