-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced Storage Docs #5715
Advanced Storage Docs #5715
Conversation
I just want to say for the record that we will make big changes to storage to make it more intuitive in the near future, so much of this will likely have to be updated. Still valuable to document the current behavior, of course. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you! What do you think about making pages in the common collections chapter for storagebytes
, storagestring
, and a nested collections page so the contract storage page isn't quite so long?
Having a table of contents at the top of the contract storage page would also be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, happy to approve once above comments are addressed
Yes I am aware. The changes here also update the outline and format of the documentation which should be carried over to any updates to storage made |
Common Collections is missing a lot of data types, such as Unfortunately, a table of contents isn't compatible with CI. I had one added and there are a number of resulting errors. Updates to CI would need to be made in another PR. |
Description
There have been a number of questions on the forum regarding storage and the section needed and update. The following changes have been made:
StorageMap
StorageVec
StorageString
StorageBytes
StorageVec
andStorageMap
StorageString
andStorageMap
StorageBytes
andStorageVec
Added table of contentsRemoved due to CI errors not accepting TOB formatStorageString
StorageBytes
StorageKey
Checklist
Breaking*
orNew Feature
labels where relevant.