Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Native Asset Docs #5808

Merged
merged 12 commits into from
Apr 8, 2024
Merged

Expand Native Asset Docs #5808

merged 12 commits into from
Apr 8, 2024

Conversation

bitzoic
Copy link
Member

@bitzoic bitzoic commented Apr 1, 2024

Description

  • Additional docs covering Native Assets including:
    • EVM vs FuelVM Assets
    • What AssetId is
    • How to use AssetId
    • What SubId is
    • What the default asset is
    • How to mint coins
    • How to burn coins
    • How to transfer coins
    • How to check contract balances
    • How to check transaction values
    • How to receive assets in contracts
    • ERC-20 equivalent example
    • ERC-1155 equivalent example
  • The Liquidity Pool example has been moved to its own section in examples

These changes were originally included in #5806 but have been pulled out into a separate PR

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@bitzoic bitzoic added the The Sway Book Everything to do with the Sway Book label Apr 1, 2024
@bitzoic bitzoic requested review from a team April 1, 2024 05:48
@bitzoic bitzoic self-assigned this Apr 1, 2024
Copy link
Contributor

@sarahschwartz sarahschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I just left some nits

docs/book/src/examples/liquidity_pool.md Outdated Show resolved Hide resolved
docs/book/src/blockchain-development/native_assets.md Outdated Show resolved Hide resolved
docs/book/src/blockchain-development/native_assets.md Outdated Show resolved Hide resolved
@bitzoic bitzoic requested review from sarahschwartz and a team April 2, 2024 06:11
K1-R1
K1-R1 previously approved these changes Apr 2, 2024
Copy link
Contributor

@K1-R1 K1-R1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

docs/book/src/blockchain-development/native_assets.md Outdated Show resolved Hide resolved
docs/book/src/blockchain-development/native_assets.md Outdated Show resolved Hide resolved
K1-R1
K1-R1 previously approved these changes Apr 4, 2024
@K1-R1 K1-R1 requested a review from a team April 4, 2024 21:10
@bitzoic bitzoic requested a review from a team April 4, 2024 23:21
@bitzoic bitzoic merged commit a386e7b into master Apr 8, 2024
39 checks passed
@bitzoic bitzoic deleted the bitzoic-native-asset-docs branch April 8, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
The Sway Book Everything to do with the Sway Book
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants