-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GM opcode to fetch the base_asset_id #5806
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependent on #5807 |
Waiting for Sway to update to Fuel-Core v0.24.0 |
K1-R1
previously approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based
dmihal
previously approved these changes
Apr 1, 2024
bitzoic
added a commit
that referenced
this pull request
Apr 8, 2024
## Description - Additional docs covering Native Assets including: - EVM vs FuelVM Assets - What `AssetId` is - How to use `AssetId` - What `SubId` is - What the default asset is - How to mint coins - How to burn coins - How to transfer coins - How to check contract balances - How to check transaction values - How to receive assets in contracts - ERC-20 equivalent example - ERC-1155 equivalent example - The Liquidity Pool example has been moved to its own section in examples These changes were originally included in #5806 but have been pulled out into a separate PR ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers. --------- Co-authored-by: K1-R1 <77465250+K1-R1@users.noreply.github.com>
IGI-111
previously approved these changes
Apr 16, 2024
IGI-111
previously approved these changes
Apr 18, 2024
K1-R1
previously approved these changes
Apr 19, 2024
SwayStar123
previously approved these changes
Apr 19, 2024
K1-R1
approved these changes
Apr 19, 2024
SwayStar123
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Base asset ID is no longer a constant. It is now stored in memory and retrieved using the
GM
opcode. More information can be found here.Breaking Changes
BASE_ASSET_ID
constant has been removed.AssetId::base_asset_id()
is nowAssetId::base()
.Checklist
Breaking*
orNew Feature
labels where relevant.