Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GM opcode to fetch the base_asset_id #5806

Merged
merged 23 commits into from
Apr 19, 2024
Merged

Use GM opcode to fetch the base_asset_id #5806

merged 23 commits into from
Apr 19, 2024

Conversation

bitzoic
Copy link
Member

@bitzoic bitzoic commented Apr 1, 2024

Description

The Base asset ID is no longer a constant. It is now stored in memory and retrieved using the GM opcode. More information can be found here.

Breaking Changes

  • The BASE_ASSET_ID constant has been removed.
  • AssetId::base_asset_id() is now AssetId::base().

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@bitzoic bitzoic added lib: std Standard library breaking May cause existing user code to break. Requires a minor or major release. labels Apr 1, 2024
@bitzoic bitzoic requested review from a team April 1, 2024 04:22
@bitzoic bitzoic self-assigned this Apr 1, 2024
@bitzoic bitzoic linked an issue Apr 1, 2024 that may be closed by this pull request
@bitzoic bitzoic added the The Sway Book Everything to do with the Sway Book label Apr 1, 2024
@bitzoic bitzoic marked this pull request as ready for review April 1, 2024 04:59
@bitzoic
Copy link
Member Author

bitzoic commented Apr 1, 2024

Dependent on #5807

@bitzoic bitzoic removed the request for review from a team April 1, 2024 05:40
@bitzoic bitzoic removed the The Sway Book Everything to do with the Sway Book label Apr 1, 2024
@bitzoic
Copy link
Member Author

bitzoic commented Apr 1, 2024

Waiting for Sway to update to Fuel-Core v0.24.0

@bitzoic bitzoic mentioned this pull request Apr 1, 2024
8 tasks
@bitzoic bitzoic marked this pull request as draft April 1, 2024 05:54
K1-R1
K1-R1 previously approved these changes Apr 1, 2024
Copy link
Contributor

@K1-R1 K1-R1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based

dmihal
dmihal previously approved these changes Apr 1, 2024
bitzoic added a commit that referenced this pull request Apr 8, 2024
## Description

- Additional docs covering Native Assets including:
     - EVM vs FuelVM Assets
     - What `AssetId` is
     - How to use `AssetId`
     - What `SubId` is
     - What the default asset is
     - How to mint coins
     - How to burn coins
     - How to transfer coins
     - How to check contract balances
     - How to check transaction values
     - How to receive assets in contracts
     - ERC-20 equivalent example
     - ERC-1155 equivalent example
- The Liquidity Pool example has been moved to its own section in
examples

These changes were originally included in
#5806 but have been pulled out into
a separate PR

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.

---------

Co-authored-by: K1-R1 <77465250+K1-R1@users.noreply.github.com>
@bitzoic bitzoic requested review from dmihal, K1-R1, IGI-111 and a team April 15, 2024 14:00
IGI-111
IGI-111 previously approved these changes Apr 16, 2024
@IGI-111 IGI-111 enabled auto-merge (squash) April 16, 2024 04:29
IGI-111
IGI-111 previously approved these changes Apr 18, 2024
K1-R1
K1-R1 previously approved these changes Apr 19, 2024
SwayStar123
SwayStar123 previously approved these changes Apr 19, 2024
@IGI-111 IGI-111 merged commit 11f9c0e into master Apr 19, 2024
36 checks passed
@IGI-111 IGI-111 deleted the bitzoic-5786 branch April 19, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking May cause existing user code to break. Requires a minor or major release. lib: std Standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use dynamically configured base assert ID in std-lib
5 participants