Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test SDK Harness to fuel-core v0.24.2 and Fuels v0.57.0 #5858

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

bitzoic
Copy link
Member

@bitzoic bitzoic commented Apr 15, 2024

Description

The SDK Harness must be updated to the latest versions of fuel-core and fuels-rs for #5786

GTF constants have been removed to match the current Fuel-VM instruction set

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@bitzoic bitzoic added lib: std Standard library testing General testing breaking May cause existing user code to break. Requires a minor or major release. labels Apr 15, 2024
@bitzoic bitzoic requested a review from a team April 15, 2024 04:34
@bitzoic bitzoic self-assigned this Apr 15, 2024
@bitzoic bitzoic linked an issue Apr 15, 2024 that may be closed by this pull request
@kayagokalp
Copy link
Member

Thanks! Is there a reason we don't have the harness part of the workspace? Because of it this was overlooked during #5844

cc @JoshuaBatty @IGI-111

@IGI-111
Copy link
Contributor

IGI-111 commented Apr 15, 2024

IIRC we need it separate because it creates a circular dependency between the rust SDK and the compiler codebase, and there has to be some way of breaking the cycle to do an update.

@IGI-111 IGI-111 enabled auto-merge (squash) April 15, 2024 11:17
@IGI-111 IGI-111 merged commit ebd832f into master Apr 15, 2024
33 checks passed
@IGI-111 IGI-111 deleted the bitzoic-5857 branch April 15, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking May cause existing user code to break. Requires a minor or major release. lib: std Standard library testing General testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update SDK-Harness to Fuel-core v0.24.2 and Fuels v0.57.0
4 participants