Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to v0.55.0 #5872

Merged
merged 5 commits into from Apr 18, 2024
Merged

chore: bump to v0.55.0 #5872

merged 5 commits into from Apr 18, 2024

Conversation

JoshuaBatty
Copy link
Member

@JoshuaBatty JoshuaBatty commented Apr 18, 2024

Description

waiting on #5871

Copy link

Benchmark for b01f12a

Click to view benchmark
Test Base PR %
code_action 5.6±0.12ms 5.5±0.02ms -1.79%
code_lens 333.6±12.78ns 289.3±5.91ns -13.28%
compile 6.2±0.06s 6.2±0.03s 0.00%
completion 5.0±0.06ms 4.9±0.02ms -2.00%
did_change_with_caching 6.1±0.05s 6.0±0.03s -1.64%
document_symbol 947.4±10.65µs 923.5±20.91µs -2.52%
format 73.4±0.61ms 70.6±1.05ms -3.81%
goto_definition 362.6±4.52µs 361.8±4.98µs -0.22%
highlight 9.1±0.08ms 9.0±0.13ms -1.10%
hover 614.8±28.70µs 606.3±17.64µs -1.38%
idents_at_position 124.8±0.32µs 123.5±0.68µs -1.04%
inlay_hints 667.2±46.28µs 660.0±6.52µs -1.08%
on_enter 490.0±20.44ns 478.1±11.87ns -2.43%
parent_decl_at_position 3.7±0.01ms 3.7±0.02ms 0.00%
prepare_rename 356.0±3.48µs 360.7±5.74µs +1.32%
rename 9.7±0.17ms 9.6±0.14ms -1.03%
semantic_tokens 1021.1±11.08µs 1037.8±17.92µs +1.64%
token_at_position 362.5±2.17µs 419.2±2.93µs +15.64%
tokens_at_position 3.7±0.04ms 3.7±0.03ms 0.00%
tokens_for_file 419.9±2.25µs 422.0±2.70µs +0.50%
traverse 51.6±1.57ms 49.6±1.91ms -3.88%

kayagokalp
kayagokalp previously approved these changes Apr 18, 2024
@JoshuaBatty JoshuaBatty requested review from a team April 18, 2024 05:26
@JoshuaBatty JoshuaBatty marked this pull request as ready for review April 18, 2024 05:26
@kayagokalp
Copy link
Member

kayagokalp commented Apr 18, 2024

#5858 -- this is marked breaking but it is breaking from 0.53.0 perspective i believe as it is continuation of #5844. Any idea if this should be a major? Any project on 0.54.0 would break but i think without that change they are already invalid so this can be considered hotfix?

@JoshuaBatty
Copy link
Member Author

True you're right, good catch. I'll change this to be a major release now.

@JoshuaBatty JoshuaBatty changed the title chore: bump to v0.54.1 chore: bump to v0.55.0 Apr 18, 2024
kayagokalp
kayagokalp previously approved these changes Apr 18, 2024
@kayagokalp kayagokalp requested a review from a team April 18, 2024 05:33
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) April 18, 2024 05:39
Copy link

Benchmark for b2e7101

Click to view benchmark
Test Base PR %
code_action 5.3±0.11ms 5.5±0.16ms +3.77%
code_lens 294.2±7.29ns 339.3±10.64ns +15.33%
compile 6.3±0.07s 6.1±0.05s -3.17%
completion 4.8±0.12ms 5.1±0.10ms +6.25%
did_change_with_caching 6.1±0.03s 6.2±0.07s +1.64%
document_symbol 1101.8±28.58µs 975.6±48.67µs -11.45%
format 75.9±1.02ms 70.4±0.78ms -7.25%
goto_definition 365.7±5.09µs 363.2±7.07µs -0.68%
highlight 8.7±0.21ms 9.0±0.25ms +3.45%
hover 604.1±11.73µs 604.5±20.68µs +0.07%
idents_at_position 121.6±0.49µs 122.4±0.75µs +0.66%
inlay_hints 656.6±12.43µs 685.8±62.38µs +4.45%
on_enter 500.0±10.29ns 482.5±39.65ns -3.50%
parent_decl_at_position 3.6±0.02ms 3.7±0.06ms +2.78%
prepare_rename 362.1±6.61µs 362.3±8.64µs +0.06%
rename 9.3±0.21ms 9.5±0.21ms +2.15%
semantic_tokens 1053.1±14.58µs 1031.9±26.17µs -2.01%
token_at_position 354.1±2.84µs 357.5±2.69µs +0.96%
tokens_at_position 3.6±0.02ms 3.7±0.03ms +2.78%
tokens_for_file 424.3±3.99µs 427.4±3.31µs +0.73%
traverse 50.4±1.52ms 51.7±1.24ms +2.58%

@JoshuaBatty JoshuaBatty requested a review from jjcnn April 18, 2024 07:16
@JoshuaBatty JoshuaBatty requested review from a team and kayagokalp April 18, 2024 07:16
Copy link

Benchmark for 598f358

Click to view benchmark
Test Base PR %
code_action 5.4±0.12ms 5.4±0.01ms 0.00%
code_lens 287.6±10.43ns 336.1±11.17ns +16.86%
compile 6.1±0.03s 6.1±0.10s 0.00%
completion 4.8±0.08ms 4.9±0.02ms +2.08%
did_change_with_caching 6.1±0.05s 6.1±0.07s 0.00%
document_symbol 990.1±15.90µs 960.3±14.56µs -3.01%
format 74.5±1.21ms 70.1±0.60ms -5.91%
goto_definition 372.1±7.22µs 372.0±5.35µs -0.03%
highlight 8.8±0.15ms 9.0±0.07ms +2.27%
hover 612.7±19.17µs 600.4±13.56µs -2.01%
idents_at_position 122.3±0.32µs 122.8±1.60µs +0.41%
inlay_hints 663.0±29.48µs 659.9±13.33µs -0.47%
on_enter 503.1±13.10ns 484.2±35.10ns -3.76%
parent_decl_at_position 3.6±0.03ms 3.7±0.04ms +2.78%
prepare_rename 375.6±4.19µs 369.3±5.92µs -1.68%
rename 9.3±0.14ms 9.5±0.19ms +2.15%
semantic_tokens 1071.7±42.84µs 1031.7±9.44µs -3.73%
token_at_position 361.6±5.39µs 359.8±1.74µs -0.50%
tokens_at_position 3.6±0.01ms 3.7±0.04ms +2.78%
tokens_for_file 427.7±1.93µs 430.4±2.57µs +0.63%
traverse 49.4±1.84ms 50.2±1.38ms +1.62%

@JoshuaBatty JoshuaBatty merged commit 60ea55e into master Apr 18, 2024
40 checks passed
@JoshuaBatty JoshuaBatty deleted the josh/0.54.1 branch April 18, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants