-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ModuleId
instead of SourceId
as the metrics map key
#5871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ModuleId
instead of SourceId
as the metrics map key
Benchmark for d29079cClick to view benchmark
|
sdankel
approved these changes
Apr 18, 2024
Benchmark for 375c6faClick to view benchmark
|
Merged
kayagokalp
approved these changes
Apr 18, 2024
JoshuaBatty
added a commit
that referenced
this pull request
Apr 18, 2024
## Description waiting on #5871
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
language server
LSP server
P: critical
Should be looked at before anything else
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a critical bug where the server would crash if compilation was triggered from anything other than the root
main.sw
file. This was due to the metrics_map using theSourceId
rather then theModuleId
as the key.This was introduced last week in #5813 as we now need to metrics to decide if the engines should be mem swapped or discarded.
closes #5870
Checklist
Breaking*
orNew Feature
labels where relevant.