Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies and gives more control ove printing the ASM. It's a first step in harmonizing printing options for ASM and IR, where the goal is to be able to print arbitrary optimization passes in IR.
This PR:
--asm
, same as the single--ir
option.Additionally, the PR fixes the bug in the
PassManager::insert_after_each
helper function, where passes were not inserted within groups. This is a preparation step for the changes needed for improving the--ir
CLI option.Demo
Breaking Changes
CLI
Instead of existing
--intermediate-asm
and--finalized-asm
options we now have a single--asm
CLI option with parameters. The existing options should be replaced:--intermediate-asm
--asm abstract
--finalized-asm
--asm final
--intermediate-asm --finalized-asm
--asm all
Build Profile
Instead of existing
print-intermediate-asm
andprint-finalized-asm
options we now have a singleprint-asm
CLI option with parameters. E.g.:Checklist
Breaking*
orNew Feature
labels where relevant.