Add EnumVariant parsed decl and minor refactors to namespace-related code
#6062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tritao
added
the
compiler: frontend
tritao
force-pushed
the
refactor-prepare-namespaces
branch
from
38e7f2b
to
f73600f
Compare
tritao
force-pushed
the
refactor-prepare-namespaces
branch
from
f73600f
to
c0727bd
Compare
8 tasks
IGI-111
approved these changes
May 29, 2024
JoshuaBatty
approved these changes
May 31, 2024
IGI-111
added a commit
that referenced
this pull request
May 31, 2024
## Description As title PR, this unifies the different maps we had to represent both parsed and typed declaration for namespace module symbols. This simplifies all the code that handles symbols since there is a single map to represent symbols at all stages in the compiler. I tried moving all shadowing-related diagnostics to be run on the parsed declarations but it will only possible to do until the other PR for full collection/resolving is done. At the moment it leads to out of order diagnostics which breaks the test. So just left a TODO and will move those over in a separate PR once its possible to do so. Depends on #6062. ## Checklist - [ ] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [ ] I have requested a review from the relevant team or maintainers. --------- Co-authored-by: IGI-111 <igi-111@protonmail.com> Co-authored-by: Joshua Batty <joshpbatty@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So this adds a new EnumVariant declaration to the parsed tree declaration hierarchy.
This is essentially the same we do for typed declarations, its just used for diagnostics tracking purposes and is going to be used in a following namespace unification PR.
And some minor cleanup commits split off other PRs and ease review and merges.
Checklist
Breaking*orNew Featurelabels where relevant.