-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify parsed and typed symbols namespace maps. #6070
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
344f5df
to
ce88bba
Compare
ce88bba
to
b0f24cd
Compare
jjcnn
reviewed
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very good change. I've left a single comment and a nit.
IGI-111
approved these changes
May 31, 2024
JoshuaBatty
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compiler: collection
Everything to do with graph collection, type collection, and the collection context.
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As title PR, this unifies the different maps we had to represent both parsed and typed declaration for namespace module symbols.
This simplifies all the code that handles symbols since there is a single map to represent symbols at all stages in the compiler.
I tried moving all shadowing-related diagnostics to be run on the parsed declarations but it will only possible to do until the other PR for full collection/resolving is done. At the moment it leads to out of order diagnostics which breaks the test. So just left a TODO and will move those over in a separate PR once its possible to do so.
Depends on #6062.
Checklist
Breaking*
orNew Feature
labels where relevant.