Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change StorageMap's remove() to use sha256(key, self.field_id()) instead of sha256(key, self.slot()) #6135

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

bitzoic
Copy link
Member

@bitzoic bitzoic commented Jun 17, 2024

Description

Currently, the StorageMap remove() function uses the slot to compute the key to remove. When inserting, field_id is used. This has been updated. Tests that remove from a nested StorageMap have also been added.

Closes #6128

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@bitzoic bitzoic added bug Something isn't working lib: std Standard library labels Jun 17, 2024
@bitzoic bitzoic self-assigned this Jun 17, 2024
@bitzoic bitzoic requested review from a team as code owners June 17, 2024 02:44
@IGI-111 IGI-111 merged commit d9ce21c into master Jun 17, 2024
37 checks passed
@IGI-111 IGI-111 deleted the bitzoic-6128 branch June 17, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lib: std Standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StorageMap's remove() should use sha256(key, self.field_id()) instead of sha256(key, self.slot())
3 participants